chore(#40): depracate DB_ADMIN_XXX in favor of DB_XXX to aling with #41
Conversation
the rest rdbms playbooks.
|
@iocanel tks for the contribution. with the other RDBMS offerings, DB_USER is leveraged for unprivileged user accounts. But, w/ mysql for example, there are separate variables for root/admin access. w/ mssql, the SA account is that equivalent so it feels as if we should reserve the DB_USER variable for a regular user. this "user create" logic is not yet built into the mssql image or apb like it is w/ the other RDBMS offerings. some modifications would first have to be made to the image and apb before switching to a DB_USER var. |
|
So what do u suggest? Remove the deprecation comment and keep both sets around until support for admin password is added? |
|
fwiw, I want to align books as much as possible so that I caneasier maintain: https://github.com/snowdrop/servicecatalog-connector |
There was a problem hiding this comment.
@iocanel my only concern w/ this approach is that folks may get confused and think they're using an unprivileged user... but I think I'm ok w/ it until additional logic is added to offer separate users types.
| @@ -239,6 +239,9 @@ | |||
| DB_TYPE: mssql | |||
| DB_HOST: '{{ service_instance }}.{{ namespace }}.svc' | |||
| DB_PORT: '{{ service_port }}' | |||
| DB_USER: SA | |||
| DB_PASSWORD: '{{ mssql_sa_pw }}' | |||
| # deprecated: DB_ADMIN_USER and DB_ADMIN_PASSWORD will be replaced by DB_USER and DB_PASSWORD. | |||
There was a problem hiding this comment.
@iocanel let's just remove this depreciation comment for now as you suggested.
|
This is stale for way to long, closing. |
the rest rdbms playbooks.