Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functional tests #993

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Sep 27, 2021

No description provided.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@fao89 fao89 force-pushed the galaxy_func_tests branch 2 times, most recently from aaf3c54 to 3f8869b Compare September 27, 2021 04:48
@fao89 fao89 marked this pull request as ready for review September 27, 2021 05:20
@rochacbruno
Copy link
Member

/retest

Copy link
Contributor

@awcrosby awcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, LGTM

if "pulp" not in data:
self.namespace_api.create(namespace={"name": "pulp", "groups": []})

temp_path = f"/tmp/{uuid4()}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use a temp dir in a context manager to cleanup file afterwards with tempfile.TemporaryDirectory() as tmp_dir:

@rochacbruno
Copy link
Member

/retest

@fao89
Copy link
Contributor Author

fao89 commented Oct 1, 2021

Can I have this merged?

@rochacbruno rochacbruno merged commit ed72e26 into ansible:master Oct 1, 2021
newswangerd pushed a commit to newswangerd/galaxy_ng that referenced this pull request Dec 15, 2021
@newswangerd newswangerd mentioned this pull request Dec 15, 2021
newswangerd added a commit that referenced this pull request Dec 15, 2021
* Backport ed72e26 (#993)

* Refactoring + speeding up tests (#1002)

* Replace pulp.pulp_installer with pulp.squeezer to speed upload test

ansible-lint takes too much time on pulp.pulp_installer,
using pulp.squeezer to get a faster test

* Refactor functional tests

No-Issue

(cherry picked from commit 24f28be)

* Allow functional test configuration of URL and PASSWORD (#1026)

Issue: AAH-1015
(cherry picked from commit ab38653)

* Test Container Repository Tags endpoint (#1032)

* Add functional test for Container Repository Tags endpoint
Issue: AAH-906

(cherry picked from commit ada466b)

* Enable azure test at nightly latest workflow (#1005)

* Enable azure test at nightly latest workflow

No-Issue

(cherry picked from commit 7c6643e)

* Add functional tests for manifest lists (#1047)

* Add functional tests for AAH-964

Issue: AAH-964

* add cleanups

(cherry picked from commit 2a492fb)

* Backport e74ea6b (#1069)

* Move container test to api dir (#1035)

No-Issue

(cherry picked from commit 3bc4d42)

Co-authored-by: Fabricio Aguiar <[email protected]>
Co-authored-by: Bruno Rocha <[email protected]>
Co-authored-by: Brian McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants