Test Container Repository Tags endpoint #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmclaughlin
force-pushed
the
aah-906-test
branch
from
a6d7229
to
3b0af00
Compare
bmclaughlin
force-pushed
the
aah-906-test
branch
from
3b0af00
to
d258ce6
Compare
DRY test assertions Issue: AAH-906
Issue: AAH-906
Issue: AAH-906
bmclaughlin
force-pushed
the
aah-906-test
branch
4 times, most recently
from
894a43e
to
f8b32a5
Compare
mdellweg
reviewed
Oct 21, 2021
galaxy_ng/tests/functional/cli/test_container_repository_tags.py
Outdated
Show resolved
Hide resolved
Issue: AAH-906
bmclaughlin
force-pushed
the
aah-906-test
branch
from
f8b32a5
to
8c7060e
Compare
Issue: AAH-906
Issue: AAH-906
bmclaughlin
force-pushed
the
aah-906-test
branch
from
97dfd5d
to
eb0a1a6
Compare
|
/retest |
|
/retest |
|
I suspect the azure test is failing because we're missing this: pulp/pulp_container#415 |
awcrosby
suggested changes
Oct 21, 2021
|
|
||
| response = self.container_repo_tags_api.list(base_path=image_name) | ||
|
|
||
| self.assertEqual(response.meta.count, 1) |
There was a problem hiding this comment.
Recommend to do a check before and after the update, to make sure the update was the cause of the expected result, something like:
self.assertEqual(response.meta.count, 0)
self._push(image_path, local_url, self.user_admin)
...
self.assertEqual(response.meta.count, 1)
awcrosby
reviewed
Oct 21, 2021
| self.assertIn(entry.name, ["1.0"]) | ||
|
|
||
| # Delete created Execution Environment | ||
| # api does not currently support delete |
There was a problem hiding this comment.
I assume since the api does not support delete, you are using smash_client to do the delete just for cleanup?
There was a problem hiding this comment.
That is correct, I figure anyone who runs the functional tests locally will appreciate the disk space being returned.
Issue: AAH-906
awcrosby
approved these changes
Oct 21, 2021
rochacbruno
requested changes
Oct 22, 2021
Issue: AAH-906
bmclaughlin
force-pushed
the
aah-906-test
branch
from
903054b
to
604f72e
Compare
rochacbruno
approved these changes
Oct 25, 2021
jctanner
pushed a commit
to jctanner/galaxy_ng
that referenced
this pull request
Dec 1, 2021
* Add functional test for Container Repository Tags endpoint Issue: AAH-906
newswangerd
pushed a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Dec 15, 2021
* Add functional test for Container Repository Tags endpoint Issue: AAH-906 (cherry picked from commit ada466b)
Merged
newswangerd
pushed a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Dec 15, 2021
* Add functional test for Container Repository Tags endpoint Issue: AAH-906 (cherry picked from commit ada466b)
newswangerd
added a commit
that referenced
this pull request
Dec 15, 2021
* Backport ed72e26 (#993) * Refactoring + speeding up tests (#1002) * Replace pulp.pulp_installer with pulp.squeezer to speed upload test ansible-lint takes too much time on pulp.pulp_installer, using pulp.squeezer to get a faster test * Refactor functional tests No-Issue (cherry picked from commit 24f28be) * Allow functional test configuration of URL and PASSWORD (#1026) Issue: AAH-1015 (cherry picked from commit ab38653) * Test Container Repository Tags endpoint (#1032) * Add functional test for Container Repository Tags endpoint Issue: AAH-906 (cherry picked from commit ada466b) * Enable azure test at nightly latest workflow (#1005) * Enable azure test at nightly latest workflow No-Issue (cherry picked from commit 7c6643e) * Add functional tests for manifest lists (#1047) * Add functional tests for AAH-964 Issue: AAH-964 * add cleanups (cherry picked from commit 2a492fb) * Backport e74ea6b (#1069) * Move container test to api dir (#1035) No-Issue (cherry picked from commit 3bc4d42) Co-authored-by: Fabricio Aguiar <[email protected]> Co-authored-by: Bruno Rocha <[email protected]> Co-authored-by: Brian McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write functional test to test
/api/galaxy/_ui/v1/execution-environments/<repository>/_content/tags/endpoint.Issue: AAH-906