dev standalone-keycloak: use keycloak/keycloak:legacy, not latest #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when #889 was merged, the current keycloak version was 15.0.2, since 17.0.0, docker run keycloak/keycloak just shows help instead of running the server and there's a *-legacy version which still runs the server Updating to latest legacy, tested with 18.0.1-legacy (this seems related to keycloak/keycloak@30d2dcb and making https://github.com/keycloak/keycloak-containers legacy) No-Issue
|
Testing...
keep retrying the last one if it fails, until it outputs a long token. Before: and After: the script should pass (eventually), the container should not die, and there should be a token on stdout. ... then update (Keycloak login screen should load when accessing localhost:8002) |
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest |
jctanner
approved these changes
Jun 22, 2022
adityamulik
pushed a commit
to adityamulik/galaxy_ng
that referenced
this pull request
Jul 7, 2022
…sible#1323) when ansible#889 was merged, the current keycloak version was 15.0.2, since 17.0.0, docker run keycloak/keycloak just shows help instead of running the server and there's a *-legacy version which still runs the server Updating to latest legacy, tested with 18.0.1-legacy (this seems related to keycloak/keycloak@30d2dcb and making https://github.com/keycloak/keycloak-containers legacy) No-Issue
adityamulik
added a commit
to adityamulik/galaxy_ng
that referenced
this pull request
Jul 7, 2022
- pre_translation.sh - post_translation.sh Ref: https://galaxy.ansible.com/ansible/memsource Turn off collection signing in pr_check.sh (ansible#1324) No-Issue Update CRC signature defaults to become python boolean (ansible#1321) No-Issue Poll the move task(s) during integration (ansible#1325) * Poll the move task(s) during integration * Poll tasks in explicit order. No-Issue Signed-off-by: James Tanner <[email protected]> Improve waits in integration tests (ansible#1322) * Use wait_for_task util where possible * Add a wait_for_url util to better poll 404s No-Issue set signing keyring for staging and published repos (ansible#1319) Issue: AAH-1712 Proposal: provide the pulp apis as part of galaxy's supported API surface (ansible#1288) * Provide the pulp apis as part of galaxy's supported API surface Issue: AAH-1681 [bugfix] Fix signing feature flags for UI (ansible#1318) Issue: AAH-1690 Add script for updating packages across branches. (ansible#1296) No-Issue Signed-off-by: James Tanner <[email protected]> dev standalone-keycloak: use keycloak/keycloak:legacy, not latest (ansible#1323) when ansible#889 was merged, the current keycloak version was 15.0.2, since 17.0.0, docker run keycloak/keycloak just shows help instead of running the server and there's a *-legacy version which still runs the server Updating to latest legacy, tested with 18.0.1-legacy (this seems related to keycloak/keycloak@30d2dcb and making https://github.com/keycloak/keycloak-containers legacy) No-Issue [feature] Add LDAP integration (ansible#1327) Issue: AAH-1593 Co-authored-by: Chris Hambridge <[email protected]> Add user profiles to integration tests (ansible#1333) * Define allowed user profiles for ansible config fixture * Update the setup for test users * Use new org_admin user instead of context manager workaround * Ensure user is added to RH identity group even if user already created * Skip token auth for ephemeral Issue: AAH-1449 Edit integration test users to specify non-admins (ansible#1334) * Remove unused user profiles * Use the basic_user profile where possible * Explicitly use admin user where needed * Define test data in one place for all methods of calling tests * Remove an xfail to confirm test fails as expected No-Issue Update filter for indexing EEs from catalog.redhat.com (ansible#1346) Issue: AAH-1737 Add diagnose messages to the feature-flags endpoint (ansible#1332) Issue: AAH-1738 Improve integration tests and test data (ansible#1342) * Replace data fixture call with setup_test_data.py * Remove unused data setup scripts * Match python conditional to how bash checks for HUB_LOCAL * Stop skipping test for use_distribution, remove unneeded profiles * Unskip test_auth tests for standalone mode * Add integration test README No-Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when #889 was merged, the current keycloak version was 15.0.2,
since 17.0.0,
docker run keycloak/keycloakjust shows help instead of running the serverand there's a new
*-legacyversion which still runs the serverUpdating to latest legacy, tested with 18.0.1-legacy
(this seems related to keycloak/keycloak@30d2dcb and making https://github.com/keycloak/keycloak-containers legacy)
Somebody should test this actually works, I've seen it work and I've seen it fail login, either could have been caused by some extra data from running keycloak 15.0.2 which definitely works.