Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve waits in integration tests #1322

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

awcrosby
Copy link
Contributor

What is this PR doing:

Check if we need more and/or smarter waits for a potentially slower
ephemeral environment.

No-Issue

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for galaxyng failed.

Name Link
🔨 Latest commit 7ae7742
🔍 Latest deploy log https://app.netlify.com/sites/galaxyng/deploys/62b203f6cf872e0008639853

@awcrosby
Copy link
Contributor Author

/retest

@awcrosby awcrosby force-pushed the fix/integration_waits branch 3 times, most recently from 5e7f7c8 to dc138cc Compare June 17, 2022 05:06
@awcrosby
Copy link
Contributor Author

/retest

@awcrosby
Copy link
Contributor Author

/retest

2 similar comments
@awcrosby
Copy link
Contributor Author

/retest

@awcrosby
Copy link
Contributor Author

/retest

@awcrosby
Copy link
Contributor Author

/retest

@awcrosby awcrosby force-pushed the fix/integration_waits branch 2 times, most recently from 7ae7742 to 0cc97d7 Compare June 21, 2022 18:16
@awcrosby
Copy link
Contributor Author

/retest

@awcrosby awcrosby marked this pull request as ready for review June 22, 2022 01:55
@awcrosby awcrosby changed the title Fix integration test failures in pr_check.sh Improve waits in integration tests Jun 22, 2022
@awcrosby awcrosby merged commit 9d23bf6 into ansible:master Jun 22, 2022
@awcrosby awcrosby deleted the fix/integration_waits branch June 22, 2022 03:01
adityamulik pushed a commit to adityamulik/galaxy_ng that referenced this pull request Jul 7, 2022
* Use wait_for_task util where possible
* Add a wait_for_url util to better poll 404s

No-Issue
adityamulik added a commit to adityamulik/galaxy_ng that referenced this pull request Jul 7, 2022
- pre_translation.sh
- post_translation.sh

Ref: https://galaxy.ansible.com/ansible/memsource

Turn off collection signing in pr_check.sh (ansible#1324)

No-Issue

Update CRC signature defaults to become python boolean (ansible#1321)

No-Issue

Poll the move task(s) during integration (ansible#1325)

* Poll the move task(s) during integration
* Poll tasks in explicit order.

No-Issue

Signed-off-by: James Tanner <[email protected]>

Improve waits in integration tests (ansible#1322)

* Use wait_for_task util where possible
* Add a wait_for_url util to better poll 404s

No-Issue

set signing keyring for staging and published repos (ansible#1319)

Issue: AAH-1712

Proposal: provide the pulp apis as part of galaxy's supported API surface (ansible#1288)

* Provide the pulp apis as part of galaxy's supported API surface

Issue: AAH-1681

[bugfix] Fix signing feature flags for UI (ansible#1318)

Issue: AAH-1690

Add script for updating packages across branches. (ansible#1296)

No-Issue

Signed-off-by: James Tanner <[email protected]>

dev standalone-keycloak: use keycloak/keycloak:legacy, not latest (ansible#1323)

when ansible#889 was merged, the current keycloak version was 15.0.2,
since 17.0.0, docker run keycloak/keycloak just shows help instead of running the server
and there's a *-legacy version which still runs the server

Updating to latest legacy, tested with 18.0.1-legacy

(this seems related to keycloak/keycloak@30d2dcb and making https://github.com/keycloak/keycloak-containers legacy)

No-Issue

[feature] Add LDAP integration (ansible#1327)

Issue: AAH-1593

Co-authored-by: Chris Hambridge <[email protected]>

Add user profiles to integration tests (ansible#1333)

* Define allowed user profiles for ansible config fixture
* Update the setup for test users
* Use new org_admin user instead of context manager workaround
* Ensure user is added to RH identity group even if user already created
* Skip token auth for ephemeral

Issue: AAH-1449

Edit integration test users to specify non-admins (ansible#1334)

* Remove unused user profiles
* Use the basic_user profile where possible
* Explicitly use admin user where needed
* Define test data in one place for all methods of calling tests
* Remove an xfail to confirm test fails as expected

No-Issue

Update filter for indexing EEs from catalog.redhat.com (ansible#1346)

Issue: AAH-1737

Add diagnose messages to the feature-flags endpoint (ansible#1332)

Issue: AAH-1738

Improve integration tests and test data (ansible#1342)

* Replace data fixture call with setup_test_data.py
* Remove unused data setup scripts
* Match python conditional to how bash checks for HUB_LOCAL
* Stop skipping test for use_distribution, remove unneeded profiles
* Unskip test_auth tests for standalone mode
* Add integration test README

No-Issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants