Remove bump-homebrew-formula configuration #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the conversation from Homebrew/homebrew-core#149334 (comment) This updates the `download-url` input to the `bump-homebrew-formula-action` to be a URL in the format of `https://pypi.org/packages/source/a/ansible-lint/ansible-lint-<VERSION>.tar.gz`. That resource ultimately resolves to `https://files.pythonhosted.org/packages/*/*/*/ansible-lint-<VERSION>.tar.gz`, which is the URL format currently present in the homebrew-core formula. I find the latter form unwieldy, and I think that the `pypi.org`-hosted resource looks much nicer and should be the same trustworthiness.
mislav
commented
Oct 4, 2023
|
Hmm, I am now learning more about python-based formula in Homebrew-core and it seems like each formula lists its python dependencies as "resources", e.g. resource "ansible-compat" do
url "https://files.pythonhosted.org/packages/36/f9/42b44473cedbf977f8fe41e2b72ea47216f708c59bafc41ad6aa93c09a71/ansible-compat-4.1.10.tar.gz"
sha256 "2be8c7b510d2e15eed1e9ef443209d67d9aec8f427026b88936d4535ff59863d"
endMy A better course of action would be to remove the |
The bump-homebrew-formula action is non-viable for this project because it is not able to update the individual `resource` blocks of the Homebrew formula for each python dependency.
ssbarnea
changed the title
ssbarnea
approved these changes
Oct 5, 2023
|
@mislav Thanks, I really appreciate your help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the conversation from Homebrew/homebrew-core#149334 (comment) /cc @ssbarnea
This updates the
download-urlinput to thebump-homebrew-formula-actionto be a URL in the format ofhttps://pypi.org/packages/source/a/ansible-lint/ansible-lint-<VERSION>.tar.gz.That resource ultimately resolves to
https://files.pythonhosted.org/packages/*/*/*/ansible-lint-<VERSION>.tar.gz, which is the URL format currently present in the homebrew-core formula. I find the latter form unwieldy, and I think that thepypi.org-hosted resource looks much nicer and should be the same trustworthiness. I'm not familiar with python-hosted anything, so you should decide which canonical form works best for you (and for the homebrew-core team).Followup to #2982
Ref. https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=published#release
Ref. https://github.com/marketplace/actions/bump-homebrew-formula#action-inputs
Ref. Homebrew/homebrew-core#128963 (comment)