Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-lint 6.20.3 #149334

Closed

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Oct 3, 2023

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 3, 2023
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should keep the pypi source

@p-linnane
Copy link
Member

Version is up to date already. We want to keep the PyPI source, so closing this.

@p-linnane p-linnane closed this Oct 3, 2023
@ssbarnea
Copy link
Contributor Author

ssbarnea commented Oct 4, 2023

@p-linnane @SMillerDev @mislav Does this mean that I no longer need to run the https://github.com/mislav/bump-homebrew-formula-action or that I need to change it to produce different changes?

While this changes appear as coming from me, they are bot generated by https://github.com/ansible/ansible-lint/blob/main/.github/workflows/release.yml#L58-L82

mislav added a commit to mislav/ansible-lint that referenced this pull request Oct 4, 2023
Moving the conversation from Homebrew/homebrew-core#149334 (comment)

This updates the `download-url` input to the `bump-homebrew-formula-action` to be a URL in the format of `https://pypi.org/packages/source/a/ansible-lint/ansible-lint-<VERSION>.tar.gz`.

That resource ultimately resolves to `https://files.pythonhosted.org/packages/*/*/*/ansible-lint-<VERSION>.tar.gz`, which is the URL format currently present in the homebrew-core formula. I find the latter form unwieldy, and I think that the `pypi.org`-hosted resource looks much nicer and should be the same trustworthiness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants