pr_labeler: refactor new_contributor_welcome code

[gotmax23]

As of #69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's author_association flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: #204

[oraNod]

Seems fine but would be nice to test this out. @gotmax23 any suggestions on how to go about that?

[gotmax23]

Seems fine but would be nice to test this out. @gotmax23 any suggestions on how to go about that?

You could checkout the PR and set up a venv for the script:

gh pr checkout 990
cd hacking/pr_labeler
python -m venv venv
source ./venv/bin/activate
pip install -r requirements.txt

Then, you can try processing a PR from a new contributor, such as #984

$ python ./label.py pr --dry-run --force-process-closed 984
984: Welcoming new contributor
984: Adding labels 'new_contributor'
# This error is expected when using dry run mode without authentication
990: Failed to get members of @ansible/release-management-wg

and one from an existing contributor, such as this one:

$ python ./label.py pr --dry-run 990
990: Failed to get members of @ansible/release-management-wg

You see that the first welcomes the new contributor and the other does not.

[oraNod]

Thanks for the pointers on testing this @gotmax23 LGTM

[patchback]

Backport to stable-2.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 763815d on top of patchback/backports/stable-2.15/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

Backporting merged PR #990 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.15/763815d1ad4e1054226077c72a5719054637fe0b/pr-990 upstream/stable-2.15

4. Now, cherry-pick PR pr_labeler: refactor new_contributor_welcome code #990 contents into that branch:

   $ git cherry-pick -x 763815d1ad4e1054226077c72a5719054637fe0b

   If it'll yell at you with something like fatal: Commit 763815d1ad4e1054226077c72a5719054637fe0b is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 763815d1ad4e1054226077c72a5719054637fe0b

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR pr_labeler: refactor new_contributor_welcome code #990 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.15/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[gotmax23]

Thanks @oraNod!

[patchback]

Backport to stable-2.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 763815d on top of patchback/backports/stable-2.14/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

Backporting merged PR #990 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.14/763815d1ad4e1054226077c72a5719054637fe0b/pr-990 upstream/stable-2.14

4. Now, cherry-pick PR pr_labeler: refactor new_contributor_welcome code #990 contents into that branch:

   $ git cherry-pick -x 763815d1ad4e1054226077c72a5719054637fe0b

   If it'll yell at you with something like fatal: Commit 763815d1ad4e1054226077c72a5719054637fe0b is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 763815d1ad4e1054226077c72a5719054637fe0b

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR pr_labeler: refactor new_contributor_welcome code #990 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.14/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-2.16: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 763815d on top of patchback/backports/stable-2.16/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

Backporting merged PR #990 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.16/763815d1ad4e1054226077c72a5719054637fe0b/pr-990 upstream/stable-2.16

4. Now, cherry-pick PR pr_labeler: refactor new_contributor_welcome code #990 contents into that branch:

   $ git cherry-pick -x 763815d1ad4e1054226077c72a5719054637fe0b

   If it'll yell at you with something like fatal: Commit 763815d1ad4e1054226077c72a5719054637fe0b is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 763815d1ad4e1054226077c72a5719054637fe0b

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR pr_labeler: refactor new_contributor_welcome code #990 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.16/763815d1ad4e1054226077c72a5719054637fe0b/pr-990

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.