pr_labeler: new contributor welcome is borked #204
Assignees
Labels
pr_labeler
Issue or PR in the pr_labeler triager bot
tooling
This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Comments
github-actions
bot
added
the
needs_triage
gotmax23
added a commit
to gotmax23-2/ansible-documentation
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: ansible#204
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: ansible#204
gotmax23
added a commit
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: #204
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: ansible#204 (cherry picked from commit feabfb6)
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: ansible#204 (cherry picked from commit feabfb6)
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Jul 31, 2023
The Github Actions API token apparently doesn't have sufficient ACLs to retrieve this from the API. Fixes: ansible#204 (cherry picked from commit feabfb6)
|
See e.g. #257 |
samccann
removed
the
needs_triage
gotmax23
added
pr_labeler
|
This should be fixed by #621. I guess we can keep the issue open until we get a contribution from a new contributor so we can confirm this is actually fixed this time. |
|
See #671. This still doesn't work, even with the new Github App token. I'm at a bit of a loss here, so I asked in https://github.com/orgs/community/discussions/70568. |
gotmax23-2
added a commit
to gotmax23-2/ansible-documentation
that referenced
this issue
Oct 25, 2023
I am using this PR to troubleshoot ansible#204 with Github support. Nothing to see here.
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Dec 31, 2023
As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Dec 31, 2023
As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Dec 31, 2023
As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Jan 7, 2024
As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204
gotmax23
added a commit
that referenced
this issue
Jan 10, 2024
* pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of #69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: #204 * pr_labeler: address potential race condition
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Ansible Documentation
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Sep 17, 2024
* pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204 * pr_labeler: address potential race condition (cherry picked from commit 763815d)
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204 * pr_labeler: address potential race condition (cherry picked from commit 763815d)
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204 * pr_labeler: address potential race condition (cherry picked from commit 763815d)
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this issue
Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of ansible#69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: ansible#204 * pr_labeler: address potential race condition (cherry picked from commit 763815d)
oraNod
pushed a commit
that referenced
this issue
Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging (cherry picked from commit 5730ba9) * pr_labeler: add --force-process-closed flag (cherry picked from commit 44ffe0f) * pr_labeler: add warning for porting_guides changes This adds a warning message when PRs are created that edit porting_guides by someone outside of the Release Management WG. These files are automatically generated during the ansible release process and should not be modified. Fixes: #503 (cherry picked from commit d2e6625) * pr_labeler: use @release-management-wg team for porting_guide check Instead of hardcoding the list of release managers, we can use the Github API to retrieve the members of the `@ansible/release-management-wg` team. (cherry picked from commit dddfd7e) * pr_labeler: exempt bots from porting_guide check For example, patchback is not a release manager, but we still want it to backport Porting Guide PRs. (cherry picked from commit 746662c) * pr_labeler: improve porting_guide_changes template wording Co-authored-by: Sandra McCann <[email protected]> (cherry picked from commit 95ece7e) * pr_labeler: refactor new_contributor_welcome code (#990) * pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of #69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: #204 * pr_labeler: address potential race condition (cherry picked from commit 763815d) * Bump actions/setup-python from 4 to 5 (#966) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... (cherry picked from commit 466b1fd) * pr_labeler: re-architect triager script (#1882) This commit reorganizes the issue/PR triager script and updates the workflow to run more efficiently. - Make the script a proper Python package instead of an unwieldy single file - Use locked dependencies and UV to decrease workflow runtime to under 10 seconds. (cherry picked from commit 7138e42) (cherry picked from commit 1cf9f79) --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oraNod
pushed a commit
that referenced
this issue
Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging (cherry picked from commit 5730ba9) * pr_labeler: add --force-process-closed flag (cherry picked from commit 44ffe0f) * pr_labeler: add warning for porting_guides changes This adds a warning message when PRs are created that edit porting_guides by someone outside of the Release Management WG. These files are automatically generated during the ansible release process and should not be modified. Fixes: #503 (cherry picked from commit d2e6625) * pr_labeler: use @release-management-wg team for porting_guide check Instead of hardcoding the list of release managers, we can use the Github API to retrieve the members of the `@ansible/release-management-wg` team. (cherry picked from commit dddfd7e) * pr_labeler: exempt bots from porting_guide check For example, patchback is not a release manager, but we still want it to backport Porting Guide PRs. (cherry picked from commit 746662c) * pr_labeler: improve porting_guide_changes template wording Co-authored-by: Sandra McCann <[email protected]> (cherry picked from commit 95ece7e) * pr_labeler: refactor new_contributor_welcome code (#990) * pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of #69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: #204 * pr_labeler: address potential race condition (cherry picked from commit 763815d) * Bump actions/setup-python from 4 to 5 (#966) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... (cherry picked from commit 466b1fd) * pr_labeler: re-architect triager script (#1882) This commit reorganizes the issue/PR triager script and updates the workflow to run more efficiently. - Make the script a proper Python package instead of an unwieldy single file - Use locked dependencies and UV to decrease workflow runtime to under 10 seconds. (cherry picked from commit 7138e42) (cherry picked from commit 1cf9f79) --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oraNod
pushed a commit
that referenced
this issue
Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging (cherry picked from commit 5730ba9) * pr_labeler: add --force-process-closed flag (cherry picked from commit 44ffe0f) * pr_labeler: add warning for porting_guides changes This adds a warning message when PRs are created that edit porting_guides by someone outside of the Release Management WG. These files are automatically generated during the ansible release process and should not be modified. Fixes: #503 (cherry picked from commit d2e6625) * pr_labeler: use @release-management-wg team for porting_guide check Instead of hardcoding the list of release managers, we can use the Github API to retrieve the members of the `@ansible/release-management-wg` team. (cherry picked from commit dddfd7e) * pr_labeler: exempt bots from porting_guide check For example, patchback is not a release manager, but we still want it to backport Porting Guide PRs. (cherry picked from commit 746662c) * pr_labeler: improve porting_guide_changes template wording Co-authored-by: Sandra McCann <[email protected]> (cherry picked from commit 95ece7e) * pr_labeler: refactor new_contributor_welcome code (#990) * pr_labeler: add GlobalArgs.full_repo property * pr_labeler: refactor new_contributor_welcome code As of #69, the pr_labeler responds with a welcome message when an issue or PR is opened by a new contributor. It turns out this never actually worked properly. The previous method that relied on Github's `author_association` flag did not work with the app token that the pr_labeler uses. This refactors the code to figure out whether a user is a new contributor by searching the list of issues and PRs. Fixes: #204 * pr_labeler: address potential race condition (cherry picked from commit 763815d) * Bump actions/setup-python from 4 to 5 (#966) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... (cherry picked from commit 466b1fd) * pr_labeler: re-architect triager script (#1882) This commit reorganizes the issue/PR triager script and updates the workflow to run more efficiently. - Make the script a proper Python package instead of an unwieldy single file - Use locked dependencies and UV to decrease workflow runtime to under 10 seconds. (cherry picked from commit 7138e42) (cherry picked from commit 1cf9f79) --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #201. For some reason, the
author_associationshowsFIRST_TIME_CONTRIBUTORwhen I run it locally using my API key, but the Github Actions token doesn't seem to have sufficient privs and returnsNONE. Therefore, the new contributor welcome message isn't sent. I ran the triager manually for that one.The text was updated successfully, but these errors were encountered: