Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.13] pin doc requirements #270

Merged
merged 3 commits into from
Aug 10, 2023
Merged

[stable-2.13] pin doc requirements #270

merged 3 commits into from
Aug 10, 2023

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Aug 9, 2023

Fixes #60 for the stable-2.13 branch.

@oraNod oraNod requested review from felixfontein and samccann August 9, 2023 14:10
@oraNod oraNod added the doc builds Relates to building the documentation label Aug 9, 2023
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 9, 2023
@oraNod oraNod force-pushed the issue-60/pin-reqs-stable-2.13 branch from 9a10934 to 75f1ab3 Compare August 9, 2023 14:20
samccann
samccann approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on jenkins build and works!

@samccann
Copy link
Contributor

samccann commented Aug 9, 2023

@oraNod - can you also update the docs etc as you did in #256?

gotmax23
gotmax23 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@gotmax23
Copy link
Collaborator

gotmax23 commented Aug 9, 2023

@oraNod - can you also update the docs etc as you did in #256?

Good point. Let's do that before merging.

felixfontein
felixfontein reviewed Aug 9, 2023
View reviewed changes
tests/constraints.in Outdated Show resolved Hide resolved
@oraNod oraNod removed the needs_triage Needs a first human triage before being processed. label Aug 10, 2023
@oraNod
Copy link
Contributor Author

oraNod commented Aug 10, 2023

fyi, retested on jenkins and works fine

@samccann samccann merged commit 040e2f1 into ansible:stable-2.13 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samccann samccann samccann approved these changes

@gotmax23 gotmax23 gotmax23 approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
doc builds Relates to building the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oraNod @samccann @gotmax23 @felixfontein