nox: add actionlint to lint Github Actions workflows

[gotmax23]

This PR integrates actionlint into our CI pipeline to check our Github Actions for best practices and common errors.

[oraNod]

brilliant work @gotmax23

[oraNod]

Thanks for adding this and for fixing those issues in the package docs build workflow @gotmax23

[oraNod]

@gotmax23 I think this is ready to merge. Can you please add the relevant backport labels? I'm inclined to backport to stable-2.17 only but maybe we should keep this on devel until we cut stable-2.18. Thank you.

[gotmax23]

I see no reason not to backport this to all stable branches and fix any issues that may come up there too.

[gotmax23]

What do you think, @oraNod? Is there something in particular you're worried about?

[gotmax23]

In any case, I'll merge this to devel now

[gotmax23]

Rebasing on devel first

[oraNod]

@gotmax23 I'm not worried about anything necessarily but just wasn't sure. now that I think about it again I guess there's no reason not to backport. thanks for adding this and handling the merge.

[gotmax23]

Sounds good, @oraNod. Thanks!

[patchback]

Backport to stable-2.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3b43d64 on top of patchback/backports/stable-2.15/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

Backporting merged PR #1848 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.15/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848 upstream/stable-2.15

4. Now, cherry-pick PR nox: add actionlint to lint Github Actions workflows #1848 contents into that branch:

   $ git cherry-pick -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

   If it'll yell at you with something like fatal: Commit 3b43d6467dc97524a6e5184b069f4a590e9b4392 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR nox: add actionlint to lint Github Actions workflows #1848 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.15/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-2.17: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3b43d64 on top of patchback/backports/stable-2.17/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

Backporting merged PR #1848 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.17/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848 upstream/stable-2.17

4. Now, cherry-pick PR nox: add actionlint to lint Github Actions workflows #1848 contents into that branch:

   $ git cherry-pick -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

   If it'll yell at you with something like fatal: Commit 3b43d6467dc97524a6e5184b069f4a590e9b4392 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR nox: add actionlint to lint Github Actions workflows #1848 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.17/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-2.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3b43d64 on top of patchback/backports/stable-2.14/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

Backporting merged PR #1848 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.14/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848 upstream/stable-2.14

4. Now, cherry-pick PR nox: add actionlint to lint Github Actions workflows #1848 contents into that branch:

   $ git cherry-pick -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

   If it'll yell at you with something like fatal: Commit 3b43d6467dc97524a6e5184b069f4a590e9b4392 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR nox: add actionlint to lint Github Actions workflows #1848 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.14/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-2.16: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3b43d64 on top of patchback/backports/stable-2.16/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

Backporting merged PR #1848 into devel

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/ansible-documentation.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2.16/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848 upstream/stable-2.16

4. Now, cherry-pick PR nox: add actionlint to lint Github Actions workflows #1848 contents into that branch:

   $ git cherry-pick -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

   If it'll yell at you with something like fatal: Commit 3b43d6467dc97524a6e5184b069f4a590e9b4392 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 3b43d6467dc97524a6e5184b069f4a590e9b4392

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR nox: add actionlint to lint Github Actions workflows #1848 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2.16/3b43d6467dc97524a6e5184b069f4a590e9b4392/pr-1848

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[gotmax23]

Ah, this probably needs to be done manually because of the python-version conflicts...