Skip to content

Commit

Permalink
lint actionlint: enable shellcheck integration
Browse files Browse the repository at this point in the history
  • Loading branch information
gotmax23 committed Sep 17, 2024
1 parent 107a3c4 commit b5e957a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
16 changes: 9 additions & 7 deletions .github/workflows/build-package-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Set the COLLECTION_LIST variable
if: env.PACKAGE_VERSION != 'devel'
run: >-
echo COLLECTION_LIST='"${PACKAGE_VERSION}"'
echo COLLECTION_LIST="${PACKAGE_VERSION}"
>> "${GITHUB_ENV}"
- name: Set the VERSION variable
Expand All @@ -93,7 +93,7 @@ jobs:
- name: Create a tarball with the build contents
run: >-
tar -czvf
ansible-package-docs-html-"${PACKAGE_VERSION}"-$(date '+%Y-%m-%d')-${{
ansible-package-docs-html-"${PACKAGE_VERSION}"-"$(date '+%Y-%m-%d')"-${{
github.run_id
}}-${{
github.run_number
Expand All @@ -117,11 +117,13 @@ jobs:
steps:
- name: Log the workflow inputs if deployed
run: |
echo "## Deployment details :shipit:" >> "${GITHUB_STEP_SUMMARY}"
echo "Publish to: ${{ github.event.inputs.deployment-environment }}" >> "${GITHUB_STEP_SUMMARY}"
echo "Package version: ${{ github.event.inputs.ansible-package-version }}" >> "${GITHUB_STEP_SUMMARY}"
echo "Owner: ${{ github.event.inputs.repository-owner }}" >> "${GITHUB_STEP_SUMMARY}"
echo "Branch: ${{ github.event.inputs.repository-branch }}" >> "${GITHUB_STEP_SUMMARY}"
{
echo "## Deployment details :shipit:";
echo "Publish to: ${{ github.event.inputs.deployment-environment }}";
echo "Package version: ${{ github.event.inputs.ansible-package-version }}";
echo "Owner: ${{ github.event.inputs.repository-owner }}";
echo "Branch: ${{ github.event.inputs.repository-branch }}";
} >> "${GITHUB_STEP_SUMMARY}"
notify-build-failures:
if: failure()
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/reusable-pip-compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ jobs:
run: |
set -x
git diff || :
# shellcheck disable=SC2086
git add ${changed_files}
# shellcheck disable=SC2086
if git diff-index --quiet HEAD ${changed_files}; then
echo "Nothing to do!"
exit
Expand Down
2 changes: 0 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ def actionlint(session: nox.Session) -> None:
"--workdir", "/pwd",
# fmt: on
ACTIONLINT_IMAGE,
# Disable shellcheck for now
"-shellcheck=",
*session.posargs,
external=True,
)
Expand Down

0 comments on commit b5e957a

Please sign in to comment.