use ansible_facts to reference facts #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
force-pushed
the
ansible_facts
branch
from
48c9780
to
a2fd9e0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.. This change updates all references to Ansible facts from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Signed-off-by: Michal Nasiadka <[email protected]>
mnasiadka
force-pushed
the
ansible_facts
branch
from
a2fd9e0
to
170b91c
Compare
|
@uk-bolly If I can do anything to speed up merging of this - please let me know :) |
uk-bolly
added a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Mark Bolwell <[email protected]>
|
hi @mnasiadka Thank you for highlighting this and providing a very clear and concise fix, Apologies for the delay, we have had many other repositories to update along with bigger changes which affect each repository. Many thanks uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Mark Bolwell <[email protected]>
Merged
jovial
added a commit
to stackhpc/RHEL9-CIS
that referenced
this pull request
Nov 15, 2023
Also enabled testing of this in CI to prevent regressions. See: - https://docs.ansible.com/ansible/2.9/reference_appendices/config.html#inject-facts-as-vars - ansible-lockdown#54 Signed-off-by: Will Szumski <[email protected]>
jovial
added a commit
to stackhpc/RHEL9-CIS
that referenced
this pull request
Nov 15, 2023
Also enabled testing of this in CI to prevent regressions. See: - https://docs.ansible.com/ansible/2.9/reference_appendices/config.html#inject-facts-as-vars - ansible-lockdown#54 Signed-off-by: Will Szumski <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Ionut Pruteanu <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Ionut Pruteanu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts..
This change updates all references to Ansible facts from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement.
[0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars
Overall Review of Changes:
A general description of the changes made that are being requested for merge
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A