-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release to main #205
Merged
Release to main #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Sept23 to devel
Signed-off-by: Mark Bolwell <[email protected]>
updated discord link in readme
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
fix rule_1.8.1.1
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Goss version
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
…ng 0600 #173 Signed-off-by: rjacobs1990 <[email protected]>
Signed-off-by: rjacobs1990 <[email protected]>
updates: - [github.com/gitleaks/gitleaks: v8.18.1 → v8.18.2](gitleaks/gitleaks@v8.18.1...v8.18.2) - [github.com/ansible-community/ansible-lint: v6.22.2 → v24.2.0](ansible/ansible-lint@v6.22.2...v24.2.0) - [github.com/adrienverge/yamllint.git: v1.33.0 → v1.34.0](https://github.com/adrienverge/yamllint.git/compare/v1.33.0...v1.34.0)
With an AD account there isn't an entry in the /etc/shadow file. This caused the password length check to treat it as a zero length password. Now local password check is skipped for AD account. Also added an additional check for a locked local account for the sudo user. Signed-off-by: John Foster <[email protected]>
Signed-off-by: Michael Hicks <[email protected]>
Signed-off-by: John Foster <[email protected]>
findings in issue #168. Changed vars on line 233 to use dictionary. Signed-off-by: John Foster <[email protected]>
fixing some mismatched tags and tasks in 5.6.1.x
…ain_variables Using a patch to refactor doc-extension
Siemens/feat/bgrubby usage for params
…nfig [pre-commit.ci] pre-commit autoupdate
Update cis_6.1.x.yml
oscap scan found 2 issues in sshd configuration override files
…pyPath Replacing vars according to Audit needs
Signed-off-by: John Foster <[email protected]>
Bugfix 5 3 4 against issue #176
fix: idempotency molecule issue fixed for logfiles #173
* change logic thanks to @rjacobs1990 see #175 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @ipruteani-sie #134 Signed-off-by: Mark Bolwell <[email protected]> * Thanks to @stwongst #125 Signed-off-by: Mark Bolwell <[email protected]> * thanks to @sgomez86 #146 Signed-off-by: Mark Bolwell <[email protected]> * Added updates from #115 Signed-off-by: Mark Bolwell <[email protected]> * removed rp_filter in post added in error Signed-off-by: Mark Bolwell <[email protected]> * updated yamllint precommit Signed-off-by: Mark Bolwell <[email protected]> * updated fqcn fo json_query Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * fix typo for virt type query Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
updates: - [github.com/adrienverge/yamllint.git: v1.34.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.34.0...v1.35.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* change logic thanks to @rjacobs1990 see #175 * 1.2.1 force gpg import rhel * fix missing facts --------- Signed-off-by: Mark Bolwell <[email protected]>
* Issue #170, PR #181 thanks to @ipruteanu-sie * issue #182, PR #183 thansk to @ipruteanu-sie * PR #180 thanks to @ipruteanu-sie and @raabf * Addressed PR #165 thanks to @ipruteanu-sie * PT #184 addressed thansk to @ipruteanu-sie * updated credits * typo and ssh allow_deny comments * enable OS check --------- Signed-off-by: Mark Bolwell <[email protected]>
* Fixed issues with 4.1.1.2 and 4.1.1.3 Now handle multiple kernels and are idempotent Signed-off-by: John Foster <[email protected]> * Fixed issues with 4.1.1.2 and 4.1.1.3 Now handle multiple kernels and are idempotent Removed debug messages Signed-off-by: John Foster <[email protected]> --------- Signed-off-by: John Foster <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Issue #170, PR #181 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * issue #182, PR #183 thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PR #180 thanks to @ipruteanu-sie and @raabf Signed-off-by: Mark Bolwell <[email protected]> * Addressed PR #165 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PT #184 addressed thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * updated credits Signed-off-by: Mark Bolwell <[email protected]> * typo and ssh allow_deny comments Signed-off-by: Mark Bolwell <[email protected]> * enable OS check Signed-off-by: Mark Bolwell <[email protected]> * PR - #198 addressed thanks to @brakkio86 Signed-off-by: Mark Bolwell <[email protected]> * Addressed issue #190 Signed-off-by: Mark Bolwell <[email protected]> * Additional vars for issue #190 Signed-off-by: Mark Bolwell <[email protected]> * updated pre-commit version Signed-off-by: Mark Bolwell <[email protected]> * consistent quotes around mode Signed-off-by: Mark Bolwell <[email protected]> * moved audit added discoveries Signed-off-by: Mark Bolwell <[email protected]> * removed unneeded vars Signed-off-by: Mark Bolwell <[email protected]> * audit moved to prelim Signed-off-by: Mark Bolwell <[email protected]> * tidy up Signed-off-by: Mark Bolwell <[email protected]> * improved new variable usage Signed-off-by: Mark Bolwell <[email protected]> * fixed logic 6.2.10 Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * addressed #197 thanks to @mark-tomich Signed-off-by: Mark Bolwell <[email protected]> * updates for audit section Signed-off-by: Mark Bolwell <[email protected]> * fixed naming Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * added prelim to includes Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/ansible-community/ansible-lint: v24.2.1 → v24.2.2](ansible/ansible-lint@v24.2.1...v24.2.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mark Bolwell <[email protected]>
georgenalen
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Many issues, updates and improvements
audit capability
pre-commit
Issue Fixes:
#60
#54
#93
#95
#96
#97
#98
#99
#100
#103
#105
#108
#110
#112
#119
#120
#121
#127
#129
#131
#133
#136
#138
#140
#143
#145
#148
#150
#151
#152
#154
#159
#164
#167
#169
#173
#174
#175
#177
#178
#179
#185
#186
#188
#192
#201
#202
#204
Enhancements:
Updated to pre-commit plugins
Audit capability - audit_only
updates for audit copy and get url
audit moved to earlier in the playbook
How has this been tested?:
Manually
pipelines
community