Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest: change fail to fail_json function #1402

Merged
merged 2 commits into from
Jul 19, 2022
Merged

vmware_guest: change fail to fail_json function #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4343a
change fail to fail_json
Tomorrow9 Jul 19, 2022
aa91a76
add change log
Tomorrow9 Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1402-vmware_guest_change_to_fail_json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- vmware_guest - Fix no fail attribute issue (https://github.com/ansible-collections/community.vmware/issues/1401).
6 changes: 3 additions & 3 deletions plugins/modules/vmware_guest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3373,13 +3373,13 @@ def main():
# Check requirements for virtualization based security
if pyv.params['hardware']['virt_based_security']:
if not pyv.params['hardware']['nested_virt']:
pyv.module.fail("Virtualization based security requires nested virtualization. Please enable nested_virt.")
pyv.module.fail_json(msg="Virtualization based security requires nested virtualization. Please enable nested_virt.")

if not pyv.params['hardware']['secure_boot']:
pyv.module.fail("Virtualization based security requires (U)EFI secure boot. Please enable secure_boot.")
pyv.module.fail_json(msg="Virtualization based security requires (U)EFI secure boot. Please enable secure_boot.")

if not pyv.params['hardware']['iommu']:
pyv.module.fail("Virtualization based security requires I/O MMU. Please enable iommu.")
pyv.module.fail_json(msg="Virtualization based security requires I/O MMU. Please enable iommu.")

# Check if the VM exists before continuing
vm = pyv.get_vm()
Expand Down