Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest: change fail to fail_json function #1402

Merged
merged 2 commits into from
Jul 19, 2022
Merged

vmware_guest: change fail to fail_json function #1402

merged 2 commits into from
Jul 19, 2022

Conversation

Tomorrow9
Copy link
Collaborator

@Tomorrow9 Tomorrow9 commented Jul 19, 2022 •
edited
Loading

Signed-off-by: Diane Wang [email protected]

SUMMARY

Fixes #1401

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Tomorrow9 added 2 commits July 19, 2022 07:35
@Tomorrow9
change fail to fail_json
7c4343a 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
add change log
aa91a76 
Signed-off-by: Diane Wang <[email protected]>
@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 4m 08s
❌ ansible-test-sanity-docker-devel FAILURE in 6m 23s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 8m 40s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 37s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 44s
✔️ ansible-test-units-community-vmware-python27 SUCCESS in 4m 19s
✔️ ansible-test-units-community-vmware-python36 SUCCESS in 5m 05s
✔️ ansible-test-units-community-vmware-python37 SUCCESS in 6m 18s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 16s
✔️ ansible-test-cloud-integration-vcenter7_only-python36-stable211 SUCCESS in 19m 37s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-python36-stable211 SUCCESS in 18m 46s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_1_of_2 SUCCESS in 43m 04s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_2_of_2 SUCCESS in 1h 02m 20s
✔️ ansible-galaxy-importer SUCCESS in 4m 08s

@mariolenz mariolenz closed this Jul 19, 2022
@mariolenz mariolenz reopened this Jul 19, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 4m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 08s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 14s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 30s
✔️ ansible-test-units-community-vmware-python27 SUCCESS in 5m 28s
✔️ ansible-test-units-community-vmware-python36 SUCCESS in 5m 00s
✔️ ansible-test-units-community-vmware-python37 SUCCESS in 6m 48s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 34s
✔️ ansible-test-cloud-integration-vcenter7_only-python36-stable211 SUCCESS in 21m 19s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-python36-stable211 SUCCESS in 20m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_1_of_2 SUCCESS in 43m 21s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_2_of_2 SUCCESS in 1h 03m 10s
✔️ ansible-galaxy-importer SUCCESS in 4m 52s

mariolenz
mariolenz approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz added bug This issue/PR relates to a bug mergeit labels Jul 19, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 3m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 54s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 37s
✔️ ansible-galaxy-importer SUCCESS in 4m 09s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4df54bc into ansible-collections:main Jul 19, 2022
@Tomorrow9 Tomorrow9 deleted the fix_vbs branch July 20, 2022 01:34
@mariolenz
Copy link
Collaborator

Thanks @Tomorrow9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_guest: 'AnsibleModule' object has no attribute 'fail'
2 participants
@Tomorrow9 @mariolenz