postgresql_idx: consider schema name when checking #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking to see if an index exists, the schema name needs to be taken into account. That is, the same name can exist in multiple schemas. Fixes ansible-collections#692
rlaager
force-pushed
the
postgresql_idx-schema
branch
from
85fb83c to
e8b980f
Compare
|
Done. I'm not sure how verbose you want me to be. I can drop the additional sentences if you prefer shorter. Also, I wasn't able to find documentation on things like line length, so let me know if I need to rewrap the code (the exec_sql statement) or the changelog fragment. |
hunleyd
approved these changes
May 9, 2024
Andersson007
approved these changes
May 10, 2024
|
@rlaager hi, welcome to the project and thanks for the contribution! |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #694 🤖 @patchback |
|
Merged! |
hunleyd
pushed a commit
that referenced
this pull request
May 10, 2024
When checking to see if an index exists, the schema name needs to be taken into account. That is, the same name can exist in multiple schemas. Fixes #692 (cherry picked from commit 09fec84) Co-authored-by: Richard Laager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When checking to see if an index exists, the schema name needs to be taken into account. That is, the same name can exist in multiple schemas.
Fixes #692
ISSUE TYPE
COMPONENT NAME
community.general.postgresql_idx