postgresql_idx: consider schema name when checking

When checking to see if an index exists, the schema name needs to be taken into account. That is, the same name can exist in multiple schemas. Fixes #692
ansible-collections · May 8, 2024 · e8b980f · e8b980f
1 parent 6820418
commit e8b980f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/693-idx-consider-schema.yaml b/changelogs/fragments/693-idx-consider-schema.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+  - postgresql_idx - consider schema name when checking for index (https://github.com/ansible-collections/community.postgresql/issues/692).  Index names are only unique within a schema. This allows using the same index name in multiple schemas.
diff --git a/plugins/modules/postgresql_idx.py b/plugins/modules/postgresql_idx.py
@@ -344,9 +344,10 @@ def __exists_in_db(self):
                  "ON i.indexname = c.relname "
                  "JOIN pg_catalog.pg_index AS pi "
                  "ON c.oid = pi.indexrelid "
-                 "WHERE i.indexname = %(name)s")
+                 "WHERE i.schemaname = %(schema)s "
+                 "AND i.indexname = %(name)s")
 
-        res = exec_sql(self, query, query_params={'name': self.name}, add_to_executed=False)
+        res = exec_sql(self, query, query_params={'schema': self.schema, 'name': self.name}, add_to_executed=False)
         if res:
             self.exists = True
             self.info = dict(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- postgresql_idx - consider schema name when checking for index (https://github.com/ansible-collections/community.postgresql/issues/692). Index names are only unique within a schema. This allows using the same index name in multiple schemas.