edgeos: Always exit configure mode #7
Conversation
|
Please also add a changelog fragment here. |
|
"edgeos module: Fix false-positive change reports in --check mode" |
bugfixes:
- edgeos - Fix false-positive change reports in check mode |
|
(in |
Previously, the configure mode was kept active when not committing the changes. This made later invocations of `show configuration commands` invalid (because that command must be executed outside of configure mode) which caused all later edgeos_config module invocations in check_mode to erroneously return a changed state.
|
Done. And I can't help but say: The experience of this PR so far was the worst possible. I created it at the ansible repository, was told to recreate in the community.general repository (which didn't exist when I first created the PR), there I was told to recreate it in the yet-to-be-created community.network repository, where I am now told to add a changelog fragment. At no point did I receive any feedback about the content of the PR, whether it had any chances of being accepted or whatever. |
|
@felixfontein Even though I am not @mjbnz, I'll take the liberty of saying "Yes, it does". |
|
@jplitza also fine with me. I don't know who is looking after the edge module(s), I'm just trying to connect people who seem to be interested in it. |
SUMMARY
Previously, the configure mode was kept active when not committing the changes.
This made later invocations of show configuration commands invalid (because
that command must be executed outside of configure mode) which caused all later
edgeos_config module invocations in check_mode to erroneously return a changed
state.
I have tested that the behavior in check_mode is fixed and unchanged (working) without check_mode.
Fixes ansible/ansible#68350
Also fixes another bug that edgeos_facts doesn't work after an edgeos invocation in check mode.
ISSUE TYPE
COMPONENT NAME
edgeos
ADDITIONAL INFORMATION