edgeos: Always exit configure mode #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the configure mode was kept active when not committing the changes. This made later invocations of `show configuration commands` invalid (because that command must be executed outside of configure mode) which caused all later edgeos_config module invocations in check_mode to erroneously return a changed state.
felixfontein
requested changes
Apr 1, 2020
There was a problem hiding this comment.
The network modules are currently moved out of this collection into a new community.network collection. While that move is in progress, no network PRs will be merged. Once the move is complete, we'll write here where to recreate this PR. Sorry for the inconvenience!
(Marking with a "Change Request" review so that this won't be accidentally merged.)
CC @gundalow
|
The new community.network collection is online: https://github.com/ansible-collections/community.network Tests are not yet working properly, but if you want you can already migrate your PR there! |
|
Replaced by ansible-collections/community.network#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously, the configure mode was kept active when not committing the changes.
This made later invocations of
show configuration commandsinvalid (becausethat command must be executed outside of configure mode) which caused all later
edgeos_config module invocations in check_mode to erroneously return a changed
state.
I have tested that the behavior in check_mode is fixed and unchanged (working) without check_mode.
Fixes ansible/ansible#68350
ISSUE TYPE
COMPONENT NAME
edgeos