Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_user: replace VALID_PRIVS by get_valid_privs() function #217

Merged
merged 3 commits into from
Sep 23, 2021
Merged

mysql_user: replace VALID_PRIVS by get_valid_privs() function #217

merged 3 commits into from
Sep 23, 2021

Conversation

rsicart
Copy link
Contributor

@rsicart rsicart commented Sep 22, 2021

SUMMARY

mysql_user: replace VALID_PRIVS by get_valid_privs() function

As commented in #77 .

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/user.py VALID_PRIVS

@codecov
Copy link

codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #217 (4e3c741) into main (6635906) will increase coverage by 0.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   77.53%   77.60%   +0.07%     
==========================================
  Files          24       24              
  Lines        2163     2170       +7     
  Branches      509      510       +1     
==========================================
+ Hits         1677     1684       +7     
  Misses        319      319              
  Partials      167      167
Impacted Files Coverage Δ
plugins/module_utils/user.py 81.67% <77.77%> (+0.20%) ⬆️
plugins/modules/mysql_role.py 80.45% <100.00%> (+0.06%) ⬆️
plugins/modules/mysql_user.py 79.59% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6635906...4e3c741. Read the comment docs.

@Andersson007
Copy link
Collaborator

@rsicart thanks for the PR! Could you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment

@Andersson007
Copy link
Collaborator

@bmalynovytch @Jorge-Rodriguez what do you think?

Jorge-Rodriguez
Jorge-Rodriguez approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@Jorge-Rodriguez Jorge-Rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This may make removal of REQUIRESSL even easier

@Andersson007
Copy link
Collaborator

Cool, thank you all for the feedback! If no objections, I'll merge this PR tomorrow.

bmalynovytch
bmalynovytch approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@bmalynovytch bmalynovytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not tested

@rsicart
Copy link
Contributor Author

rsicart commented Sep 22, 2021 •
edited
Loading

Thank you all for your time and work!

@Andersson007 Andersson007 merged commit 0ce1fa1 into ansible-collections:main Sep 23, 2021
@Andersson007
Copy link
Collaborator

@rsicart thanks for the contribution! @bmalynovytch @Jorge-Rodriguez thanks for reviewing!

Andersson007 pushed a commit to Andersson007/community.mysql that referenced this pull request Sep 23, 2021
@rsicart @Andersson007
mysql_user: replace VALID_PRIVS by get_valid_privs() function (ansibl…
e8960d5 
…e-collections#217)

* mysql_user: replace VALID_PRIVS by get_valid_privs() function

* Add EXTRA_PRIVS in case we need to add more privs in the future

* Add changelog fragment

(cherry picked from commit 0ce1fa1)
@Andersson007 Andersson007 mentioned this pull request Sep 23, 2021
Merged
Andersson007 added a commit that referenced this pull request Sep 23, 2021
@Andersson007 @int32bit @rsicart
[stable-2] Backport stable 2 4 (#219)
c5676ff 
* Fix wrong impl for mysql (#210)

If 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql.

(cherry picked from commit 6635906)

* Update README.md (#216)

(cherry picked from commit 4de0e25)

* mysql_user: replace VALID_PRIVS by get_valid_privs() function (#217)

* mysql_user: replace VALID_PRIVS by get_valid_privs() function

* Add EXTRA_PRIVS in case we need to add more privs in the future

* Add changelog fragment

(cherry picked from commit 0ce1fa1)

Co-authored-by: int32bit <[email protected]>
Co-authored-by: R.Sicart <[email protected]>
@Andersson007
Copy link
Collaborator

@rsicart I've just released 2.3.0. It contains your changes and among other things mysql_role new module. The release is available via ansible-galaxy command or directly on https://galaxy.ansible.com/community/mysql.
If i understand correctly, you use MariaDB. We unfortunately don't have MariaDB in our CI. I tested it manually when developing but the more eyes the better.
So if you'd like to contribute more but don't know how, testing of mysql_role would be much appreciated:)
We also have plenty of issues open / abandoned PRs to complete:)

@rsicart rsicart mentioned this pull request Sep 23, 2021
Open
@Andersson007 Andersson007 mentioned this pull request Sep 23, 2021
Closed
@rsicart
Copy link
Contributor Author

rsicart commented Sep 23, 2021

Cool! Happy to contribute :)
Actually I use percona with debian buster. If I have more feedback I'll don't hesitate to open an Issue or PR. Thanks!

This was referenced Oct 18, 2021
Closed
Merged
Closed
@rsicart rsicart deleted the rsi/valid-privs-from-show-privileges branch February 15, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 left review comments

@bmalynovytch bmalynovytch bmalynovytch approved these changes

@Jorge-Rodriguez Jorge-Rodriguez Jorge-Rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsicart @Andersson007 @Jorge-Rodriguez @bmalynovytch