-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong impl for mysql #210
Conversation
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 24 24
Lines 2163 2163
Branches 509 509
=======================================
Hits 1677 1677
Misses 319 319
Partials 167 167
Continue to review full report at Codecov.
|
The failing task is
|
If 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql.
@int32bit (the codecove errors are unrelated) thanks for the contribution! |
BTW it's better to use dedicated branches for submitting pull requests than |
If 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql. (cherry picked from commit 6635906)
* Fix wrong impl for mysql (#210) If 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql. (cherry picked from commit 6635906) * Update README.md (#216) (cherry picked from commit 4de0e25) * mysql_user: replace VALID_PRIVS by get_valid_privs() function (#217) * mysql_user: replace VALID_PRIVS by get_valid_privs() function * Add EXTRA_PRIVS in case we need to add more privs in the future * Add changelog fragment (cherry picked from commit 0ce1fa1) Co-authored-by: int32bit <[email protected]> Co-authored-by: R.Sicart <[email protected]>
SUMMARY
If 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql.
ISSUE TYPE
COMPONENT NAME
community.mysql
ADDITIONAL INFORMATION
MariaDB output:
MySQL output:
According to the above output, if 'mariadb' in version info, the db instance should be mariadb(reverse in code) rather than mysql.