Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcommands parameter for module alternatives. #4654

Merged
merged 28 commits into from
Jun 6, 2022
Merged

Add subcommands parameter for module alternatives. #4654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fad8c09
Add slaves parameter for module alternatives.
jiuka May 9, 2022
b7606a5
alternatives: Improve documentation abous slaves parameter
jiuka May 9, 2022
88a00ae
alternatives: Apply suggestions from code review
jiuka May 10, 2022
fc2b694
alternatives: Add schangelog for slaves parameter
jiuka May 10, 2022
910e7fe
alernatives: Add integration tests
jiuka May 10, 2022
b3658ed
alternatives: Improv tests
jiuka May 11, 2022
197e98c
alternatives: Update tests/integration/targets/alternatives/tasks/sla…
jiuka May 11, 2022
81cf47d
alternatives: Rework logic to support updating priority and subcommands
jiuka May 12, 2022
4516c88
alternatives: Use more inclusive naming
jiuka May 12, 2022
8ee5cfd
alternatives: Fix linter warnings
jiuka May 12, 2022
7ff3983
alternatives: Dont fail if link is absent
jiuka May 12, 2022
e9a128f
alternatives: Update changelog fragment
jiuka May 12, 2022
c242382
alternatives: Add tests for prio change and removing
jiuka May 13, 2022
63e1d2c
alternatives: Apply suggestions from code review
jiuka May 13, 2022
aaf2a83
alternatives: Add `state=auto`to reset mode to auto
jiuka May 13, 2022
87b9f66
alternatives: Fix linter warnings
jiuka May 13, 2022
708ef3e
alternatives: Fix documentation.
jiuka May 14, 2022
851be5e
alternatives: Combine multiple messages.
jiuka May 14, 2022
56a09b7
alternatives: Set command env for all commands.
jiuka May 14, 2022
6ef4b5f
alternatives: Do not update subcommands if parameter is omited
jiuka May 14, 2022
66a7b3d
alternatives: Fix a bug with python 2.7 var scoping
jiuka May 15, 2022
e2751ce
alternatives: Improce diff before generation
jiuka May 15, 2022
1935016
alternatives: Fix linter warnings
jiuka May 15, 2022
b30160b
alternatives: Fix test names
jiuka May 16, 2022
8ed1836
alternatives: Simplify subcommands handling and improve diffs
jiuka May 16, 2022
8c2fa33
aliases: Only test for subcommand changes if subcommands parameter is…
jiuka May 16, 2022
069eed7
Update plugins/modules/system/alternatives.py
jiuka May 17, 2022
abd45ff
Apply suggestions from code review
felixfontein May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/BOTMETA.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ files:
$modules/system/alternatives.py:
maintainers: mulby
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be glad if you would consider to add yourself here instead of at the ignore list :) Then you'd be one of the module maintainers (resp. probably the only active one since right now nobody seems to be active) for the alternatives module, and would be informed of issues and new PRs for that module.

labels: alternatives
ignore: DavidWittman
ignore: DavidWittman jiuka
$modules/system/aix_lvol.py:
maintainers: adejoux
$modules/system/awall.py:
Expand Down
3 changes: 3 additions & 0 deletions changelogs/fragments/4654-alternatives-add-subcommands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
minor_changes:
- alternatives - add ``subcommands`` parameter (https://github.com/ansible-collections/community.general/pull/4654).
jiuka marked this conversation as resolved.
Show resolved Hide resolved
- alternatives - add ``state=absent`` to be able to remove an alternative (https://github.com/ansible-collections/community.general/pull/4654).
Loading