-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subcommands parameter for module alternatives. #4654
Merged
felixfontein
merged 28 commits into
ansible-collections:main
from
jiuka:alternatives_slaves
Jun 6, 2022
Merged
Add subcommands parameter for module alternatives. #4654
felixfontein
merged 28 commits into
ansible-collections:main
from
jiuka:alternatives_slaves
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This issue/PR relates to a feature request
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
system
labels
May 9, 2022
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
Push fixes to PR branch to re-run CI
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
May 9, 2022
ansibullbot
removed
ci_verified
Push fixes to PR branch to re-run CI
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
May 9, 2022
felixfontein
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you please add a changelog fragment?
felixfontein
added
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
May 9, 2022
Co-authored-by: Felix Fontein <[email protected]>
Can you try to add tests for this? The integration tests are in tests/integration/targets/alternatives. |
ansibullbot
added
integration
tests/integration
tests
tests
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
May 10, 2022
jiuka
force-pushed
the
alternatives_slaves
branch
from
May 10, 2022 13:13
3731709
to
910e7fe
Compare
ansibullbot
added
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
May 10, 2022
ansibullbot
removed
the
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
label
May 11, 2022
…ves.yml Co-authored-by: Felix Fontein <[email protected]>
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
This issue/PR relates to a feature request
has_issue
integration
tests/integration
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
system
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a slaves parameter for the alternatives module. This helps creating groups of commands which should be switched together. For example if you switch the ansible version there is more then one binary which should change.
Fixes #3366
ISSUE TYPE
COMPONENT NAME
alternatives
ADDITIONAL INFORMATION
Based on ansible/ansible#52732