Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcommands parameter for module alternatives. #4654

Merged
merged 28 commits into from
Jun 6, 2022

Conversation

jiuka
Copy link
Contributor

@jiuka jiuka commented May 9, 2022

SUMMARY

Add a slaves parameter for the alternatives module. This helps creating groups of commands which should be switched together. For example if you switch the ansible version there is more then one binary which should change.

Fixes #3366

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

alternatives

ADDITIONAL INFORMATION

Based on ansible/ansible#52732

@ansibullbot
Copy link
Collaborator

cc @mulby
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) system labels May 9, 2022
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 9, 2022
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 9, 2022
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment?

plugins/modules/system/alternatives.py Outdated Show resolved Hide resolved
plugins/modules/system/alternatives.py Outdated Show resolved Hide resolved
plugins/modules/system/alternatives.py Outdated Show resolved Hide resolved
plugins/modules/system/alternatives.py Outdated Show resolved Hide resolved
plugins/modules/system/alternatives.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label May 9, 2022
@felixfontein
Copy link
Collaborator

Can you try to add tests for this? The integration tests are in tests/integration/targets/alternatives.

@ansibullbot ansibullbot added integration tests/integration tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 10, 2022
@jiuka jiuka force-pushed the alternatives_slaves branch from 3731709 to 910e7fe Compare May 10, 2022 13:13
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 10, 2022
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label May 11, 2022
This was referenced Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_issue integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates-alternatives slaves support
4 participants