-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up validate-modules:doc-required-mismatch #1415
Tidy up validate-modules:doc-required-mismatch #1415
Conversation
@russoz This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
cc @!UNKNOWN @Akasurde @Jmainguy @KellerFuchs @Lunik @MorrisA @NilashishC @Qalthos @SamyCoenen @Shaps @abellotti @adriane-cardozo @bcoca @brampling @briceburg @cben @clementtrebuchet @cmprescott @colin-nolan @coreywan @d-little @dagwieers @danieljaouen @danielmellado @dareko @devyanikota @dj-wasabi @dkorn @evertmulder @fgbulsoni @fishman @flynn1973 @ganeshrn @gforster @gtanzillo @indrajitr @jasperla @jpdasma @jtyr @justjais @kairoaraujo @kenichi-ogawa-1988 @krisvasudevan @kyleabenson @machacekondra @martinm82 @marvin-sinister @marwatk @matbu @mator @molekuul @natefoo @nerzhul @nurfet-becirevic @privateip @ramooncamacho @sac @scathatheworm @scodeman @sganesh-infoblox @sgargan @sjaiswal @slok @sm4rk0 @t0mk @talzur @tbielawa @tmiotto @trishnaguha @troy2914 @tzure @vedit @waheedi @wtcross @xen0l @yaacov @yeukhon @zanssa @zgalor |
Co-authored-by: Felix Fontein <[email protected]>
This reverts commit 56a02ea.
@russoz thanks for fixing more and more :) |
) * Tidy up validate-modules ignores doc-required-mismatch * Tidy up validate-modules ignores doc-required-mismatch - update on 2.11 * Fixed chengelog frag * rolledback removal of parameter from cloud/smartos/vmadm.py * removed changelog frag for the rollback * Update plugins/modules/cloud/smartos/vmadm.py Co-authored-by: Felix Fontein <[email protected]> * Revert "removed changelog frag for the rollback" This reverts commit 56a02ea. * suggestion from PR * yet another PR suggestion Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit b69ea1d)
Backport in #1417. |
* Tidy up validate-modules ignores doc-required-mismatch * Tidy up validate-modules ignores doc-required-mismatch - update on 2.11 * Fixed chengelog frag * rolledback removal of parameter from cloud/smartos/vmadm.py * removed changelog frag for the rollback * Update plugins/modules/cloud/smartos/vmadm.py Co-authored-by: Felix Fontein <[email protected]> * Revert "removed changelog frag for the rollback" This reverts commit 56a02ea. * suggestion from PR * yet another PR suggestion Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit b69ea1d) Co-authored-by: Alexei Znamensky <[email protected]>
Always a pleasure, thanks for reviewing! |
SUMMARY
Tidy up on sanity tests' ignore files, removing lines with validation-modules for these modules.
The focus was to pass the tests so no code was changed other than adjusting argument_spec for missing types or inconsistencies with the docs. The priority has been not to change any functionality, but to ensure that code and docs are synchronized.
Some lines were added back to the files, but a total of 129 lines were removed (among 2.9, 2.10 and 2.11).
ISSUE TYPE
COMPONENT NAME
plugins/modules/storage/zfs/zfs_delegate_admin.py
plugins/modules/storage/ibm/ibm_sa_vol_map.py
plugins/modules/storage/ibm/ibm_sa_vol.py
plugins/modules/storage/ibm/ibm_sa_pool.py
plugins/modules/storage/ibm/ibm_sa_host_ports.py
plugins/modules/storage/ibm/ibm_sa_host.py
plugins/modules/storage/ibm/ibm_sa_domain.py
plugins/modules/system/aix_devices.py
plugins/modules/system/osx_defaults.py
plugins/modules/storage/glusterfs/gluster_peer.py
plugins/modules/source_control/hg.py
plugins/modules/source_control/gitlab/gitlab_runner.py
plugins/modules/source_control/gitlab/gitlab_hook.py
plugins/modules/source_control/gitlab/gitlab_deploy_key.py
plugins/doc_fragments/nios.py
plugins/modules/remote_management/oneview/oneview_fc_network.py
plugins/modules/remote_management/manageiq/manageiq_provider.py
plugins/modules/remote_management/cobbler/cobbler_system.py
plugins/modules/remote_management/cobbler/cobbler_sync.py
plugins/modules/net_tools/nios/nios_a_record.py
plugins/modules/net_tools/nios/nios_aaaa_record.py
plugins/modules/net_tools/nios/nios_cname_record.py
plugins/modules/net_tools/nios/nios_dns_view.py
plugins/modules/net_tools/nios/nios_fixed_address.py
plugins/modules/net_tools/nios/nios_host_record.py
plugins/modules/net_tools/nios/nios_member.py
plugins/modules/net_tools/nios/nios_mx_record.py
plugins/modules/net_tools/nios/nios_naptr_record.py
plugins/modules/net_tools/nios/nios_ptr_record.py
plugins/modules/net_tools/nios/nios_srv_record.py
plugins/modules/net_tools/nios/nios_txt_record.py
plugins/modules/net_tools/nios/nios_zone.py
plugins/modules/net_tools/ldap/ldap_passwd.py
plugins/modules/net_tools/dnsmadeeasy.py
plugins/modules/files/xml.py
plugins/modules/database/vertica/vertica_configuration.py
plugins/modules/database/mssql/mssql_db.py
plugins/modules/database/misc/redis.py
plugins/modules/clustering/pacemaker_cluster.py
plugins/modules/clustering/consul/consul_kv.py
plugins/modules/clustering/consul/consul_acl.py
plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py
plugins/modules/cloud/smartos/vmadm.py
plugins/modules/cloud/packet/packet_volume_attachment.py
plugins/modules/cloud/packet/packet_ip_subnet.py
plugins/modules/cloud/ovirt/ovirt_scheduling_policy_facts.py
plugins/doc_fragments/online.py
ADDITIONAL INFORMATION