Tidy up validate-modules:doc-required-mismatch (#1415)

* Tidy up validate-modules ignores doc-required-mismatch * Tidy up validate-modules ignores doc-required-mismatch - update on 2.11 * Fixed chengelog frag * rolledback removal of parameter from cloud/smartos/vmadm.py * removed changelog frag for the rollback * Update plugins/modules/cloud/smartos/vmadm.py Co-authored-by: Felix Fontein <[email protected]> * Revert "removed changelog frag for the rollback" This reverts commit 56a02ea. * suggestion from PR * yet another PR suggestion Co-authored-by: Felix Fontein <[email protected]>
ansible-collections · Nov 28, 2020 · b69ea1d · b69ea1d
1 parent cff8463
commit b69ea1d
Show file tree

Hide file tree

Showing 51 changed files with 158 additions and 220 deletions.
diff --git a/changelogs/fragments/1415-valmod_req_mismatch.yml b/changelogs/fragments/1415-valmod_req_mismatch.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - vmadm - simplification of code (https://github.com/ansible-collections/community.general/pull/1415).
diff --git a/plugins/doc_fragments/nios.py b/plugins/doc_fragments/nios.py
@@ -24,7 +24,6 @@ class ModuleDocFragment(object):
           - Value can also be specified using C(INFOBLOX_HOST) environment
             variable.
         type: str
-        required: true
       username:
         description:
           - Configures the username to use to authenticate the connection to

diff --git a/plugins/doc_fragments/online.py b/plugins/doc_fragments/online.py
@@ -15,6 +15,7 @@ class ModuleDocFragment(object):
     description:
       - Online OAuth token.
     type: str
+    required: true
     aliases: [ oauth_token ]
   api_url:
     description:

diff --git a/plugins/modules/cloud/ovirt/ovirt_scheduling_policy_facts.py b/plugins/modules/cloud/ovirt/ovirt_scheduling_policy_facts.py
@@ -41,7 +41,6 @@
     id:
         description:
             - "ID of the scheduling policy."
-        required: true
     name:
         description:
             - "Name of the scheduling policy, can be used as glob expression."
@@ -77,7 +76,6 @@
 import fnmatch
 import traceback
 
-from ansible.module_utils.common.removed import removed_module
 from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.community.general.plugins.module_utils._ovirt import (
     check_sdk,

diff --git a/plugins/modules/cloud/packet/packet_ip_subnet.py b/plugins/modules/cloud/packet/packet_ip_subnet.py
@@ -48,7 +48,6 @@
   project_id:
     description:
       - UUID of a project of the device to/from which to assign/remove a subnet.
-    required: True
     type: str
 
   device_count:
@@ -63,6 +62,7 @@
       - IPv4 or IPv6 subnet which you want to manage. It must come from a reserved block for your project in the Packet Host.
     aliases: [name]
     type: str
+    required: true
 
   state:
     description:

diff --git a/plugins/modules/cloud/packet/packet_volume_attachment.py b/plugins/modules/cloud/packet/packet_volume_attachment.py
@@ -45,13 +45,15 @@
     description:
       - UUID of the project to which the device and volume belong.
     type: str
+    required: true
 
   volume:
     description:
       - Selector for the volume.
       - It can be a UUID, an API-generated volume name, or user-defined description string.
       - 'Example values: 4a347482-b546-4f67-8300-fb5018ef0c5, volume-4a347482, "my volume"'
     type: str
+    required: true
 
   device:
     description:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- vmadm - simplification of code (https://github.com/ansible-collections/community.general/pull/1415).