Replicas max per node

[WojciechowskiPiotr]

SUMMARY

Adding support for MaxReplicas Placement parameter for docker_swarm_service (requested in #7)

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

docker_swarm_service

[felixfontein]

I think you also need to update the return value documentation, since you added a new field. (I think that new field is also what makes the tests fail.)

[WojciechowskiPiotr]

ready_for_review

[felixfontein]

You should also mention replicas_max_per_node in the return example (

community.docker/plugins/modules/docker_swarm_service.py

Line 728 in 8f209e4

"replicas": 1,

). Also this needs a changelog fragment.

Besides that, looks good to me. As far as I can judge changes to this module :)

@hannseman @jwitko @dariko any comments on this?

[hannseman]

Looks good to me! 👍

[WojciechowskiPiotr]

You should also mention replicas_max_per_node in the return example (

community.docker/plugins/modules/docker_swarm_service.py

Line 728 in 8f209e4

"replicas": 1,

). Also this needs a changelog fragment.
Besides that, looks good to me. As far as I can judge changes to this module :)

@hannseman @jwitko @dariko any comments on this?

Updated

[felixfontein]

@WojciechowskiPiotr thanks for implementing this!
@hannseman thanks for reviewing!

If you have some time, can you take a look at #87, #89, #90? :) I'll also try to create a PR for #91 today, I think with that we can release 1.3.0 very soon.