docker_image: improve/fix handling of image IDs #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
|
ready_for_review |
felixfontein
changed the title
felixfontein
changed the title
|
Ok, this is now ready. |
This was referenced Feb 24, 2021
Merged
aminvakil
approved these changes
Feb 27, 2021
russoz
reviewed
Feb 28, 2021
plugins/module_utils/common.py
Outdated
| @@ -551,6 +554,11 @@ def find_image_by_id(self, image_id): | |||
| self.log("Find image %s (by ID)" % image_id) | |||
| try: | |||
| inspection = self.inspect_image(image_id) | |||
| except NotFound as exc: | |||
| if not accept_not_there: | |||
There was a problem hiding this comment.
I always try to avoid variable names with not in them. This line illustrates a bit why: reading it aloud, it goes like "if not accept not there". Maybe accept_missing_image ?
There was a problem hiding this comment.
Fixed in 7f0ec90.
russoz
reviewed
Feb 28, 2021
plugins/modules/docker_image.py
Outdated
| @@ -463,6 +480,9 @@ def absent(self): | |||
| if not self.check_mode: | |||
| try: | |||
| self.client.remove_image(name, force=self.force_absent) | |||
| except NotFound as dummy: | |||
There was a problem hiding this comment.
Since we are not really using it, I'd remove the as dummy part altogether. It does not make the code better at all.
There was a problem hiding this comment.
Fixed in b3b6da6.
|
LGTM other than the couple of minor issues above, but also putting a disclaimer: I have not used the docker modules, so not very confident on what impacts these changes might have. |
|
@aminvakil @russoz thanks a lot for reviewing this! |
felixfontein
added a commit
to felixfontein/community.general
that referenced
this pull request
Mar 8, 2021
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Mar 8, 2021
felixfontein
added a commit
to ansible-collections/community.general
that referenced
this pull request
Mar 8, 2021
relrod
pushed a commit
to ansible/ansible
that referenced
this pull request
Mar 8, 2021
…o stable-2.9. (#73817)
clrpackages
pushed a commit
to clearlinux-pkgs/ansible
that referenced
this pull request
Mar 16, 2021
…2.9.19
Alexander Sowitzki (1):
[stable-2.9] Bump azure-pipelines-test-container to version 1.8.0 (#73550)
Ashwini Mhatre (1):
[stable-2.9]:Fix IOSXR integration test (#73607)
Felix Fontein (4):
Backport of ansible-collections/community.docker@8702713 (#73638)
Backport of bugfix parts of ansible-collections/community.docker#87 to stable-2.9. (#73817)
Backport of ansible-collections/community.docker#88 to stable-1. (#73816)
Backport of ansible-collections/community.crypto#180 to stable-2.9. (#73815)
Gonéri Le Bouder (2):
ansible-test: yamllint, check the assigment (#73584)
[ansible-test] attempt to work around podman (#72096) (#73570)
Mark Chappell (2):
New AWS module mod_defaults - ec2_vpc_endpoint_service_info (#73670)
New AWS module mod_defaults - iam_saml_federation (#73669)
Matt Martz (2):
[stable-2.9] Normalize ConfigParser between Python2 and Python3 (#73715) (#73724)
[stable-2.9] Don't treat host_pinned as lockstep (#73484) (#73513)
Rhys (1):
Update mongodb replicaset check_compatibility function (#72299)
Rick Elrod (4):
Update Ansible release version to v2.9.18.post0.
New release v2.9.19rc1
Update Ansible release version to v2.9.19rc1.post0.
New release v2.9.19
Sam Doran (5):
Update signing key used in incidental_setup_flatpak_remote tests
Rebalance Windows test groups to avoid timeouts
Move win_uri to a group that does not reboot the test instance
[stable-2.9] hostname - add Almalinux support (#73619) (#73649)
[stable-2.9] Add AlmaLinux to the family of Red Hat-like operating systems (#73541) (#73544)
Zadkiel (1):
terraform: Remove line that is suppressing output being shown (#66322) (#73803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR allows to use image IDs in more contexts in docker_image. It also makes the code for loading Docker images aware of image IDs, and fixes that part of #86.
It does not allow to load multiple images though. That should be done in a new module.
ISSUE TYPE
COMPONENT NAME
docker_image