Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml #430

Merged
merged 18 commits into from
Jul 20, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Implements ansible-community/community-topics#112 (comment).

Closes #393.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

collection

@felixfontein felixfontein changed the title [WIP] Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml Jul 17, 2022
plugins/module_utils/version.py Outdated Show resolved Hide resolved
plugins/modules/docker_plugin.py Outdated Show resolved Hide resolved
@gotmax23
Copy link
Contributor

Output of reuse lint (with the colons from the copyrights removed):


reuse._util - ERROR - Could not parse '')'
reuse.project - ERROR - 'tests/sanity/extra/licenses.py' holds an SPDX expression that cannot be parsed, skipping the file

MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:

  • CHANGELOG.rst
  • changelogs/changelog.yaml
  • changelogs/fragments/430-licenses.yml
  • tests/sanity/extra/extra-docs.json
  • tests/sanity/extra/licenses.json
  • tests/sanity/extra/licenses.py -- False negative, thrown off by the other SPDX-License-Identifer text
  • tests/sanity/extra/no-unwanted-files.json
  • tests/sanity/ignore-2.10.txt
  • tests/sanity/ignore-2.11.txt
  • tests/sanity/ignore-2.12.txt
  • tests/sanity/ignore-2.13.txt
  • tests/sanity/ignore-2.14.txt
  • tests/sanity/ignore-2.9.txt

SUMMARY

  • Bad licenses:
  • Deprecated licenses:
  • Licenses without file extension:
  • Missing licenses:
  • Unused licenses:
  • Used licenses: Apache-2.0, GPL-3.0-or-later
  • Read errors: 0
  • Files with copyright information: 432 / 445
  • Files with license information: 432 / 445

Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-(


REUSE has other ways that you can add licenses to these files, but I'm fine with this implementation. All of the actual code has explicit license identifiers and copyrights.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus some minor quibbles, which you can choose how to address, this looks good to me. I didn't inspect the diff for every single file, but I ran this through your linting tool and reuse lint and checked many of the diffs.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over this again and found a couple other things to nitpick on, but overall I'm very happy with this! I'm happy to see my suggestion getting implemented 😊. Thanks for all your work on this and for writing the tools to make the process easier.

tests/sanity/extra/licenses.py Outdated Show resolved Hide resolved
tests/sanity/extra/licenses.py Show resolved Hide resolved
tests/sanity/extra/licenses.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
See [LICENSES/GPL-3.0-or-later.txt](https://github.com/ansible-collections/community.docker/blob/main/LICENSES/GPL-3.0-or-later.txt) for the full text.
See [LICENSES/GPL-3.0-or-later.txt](https://github.com/ansible-collections/community.docker/blob/main/COPYING) for the full text.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me wishes Github would properly handle symlinks instead of creating useless other features and committing license violations en masse (Copilot), but this is probably the best solution.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants