-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml #430
Move licenses to LICENSES/, use SPDX-License-Identifier, mention all licenses in galaxy.yml #430
Conversation
…licenses in galaxy.yml.
Output of reuse._util - ERROR - Could not parse '')' MISSING COPYRIGHT AND LICENSING INFORMATIONThe following files have no copyright and licensing information:
SUMMARY
Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-( REUSE has other ways that you can add licenses to these files, but I'm fine with this implementation. All of the actual code has explicit license identifiers and copyrights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minus some minor quibbles, which you can choose how to address, this looks good to me. I didn't inspect the diff for every single file, but I ran this through your linting tool and reuse lint
and checked many of the diffs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over this again and found a couple other things to nitpick on, but overall I'm very happy with this! I'm happy to see my suggestion getting implemented 😊. Thanks for all your work on this and for writing the tools to make the process easier.
Co-authored-by: Maxwell G <[email protected]>
See [LICENSES/GPL-3.0-or-later.txt](https://github.com/ansible-collections/community.docker/blob/main/LICENSES/GPL-3.0-or-later.txt) for the full text. | ||
See [LICENSES/GPL-3.0-or-later.txt](https://github.com/ansible-collections/community.docker/blob/main/COPYING) for the full text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/me wishes Github would properly handle symlinks instead of creating useless other features and committing license violations en masse (Copilot), but this is probably the best solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
SUMMARY
Implements ansible-community/community-topics#112 (comment).
Closes #393.
ISSUE TYPE
COMPONENT NAME
collection