Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Start adding SPDX-License-Identifier comments #393

Closed
wants to merge 2 commits into from

Conversation

gotmax23
Copy link
Contributor

@gotmax23 gotmax23 commented Jun 23, 2022

Automated with:

mkdir LICENSES
ln -sr COPYING LICENSES/GPL-3.0-or-later.txt
git mv PSF-license.txt LICENSES/PSF-2.0.txt
reuse addheader -l PSF-2.0 plugins/module_utils/_version.py
rg -l 'GNU General Public License v3.0+' | parallel reuse addheader -l GPL-3.0-or-later

Signed-off-by: Maxwell G [email protected]

SUMMARY

This is a WIP PR to show what adopting REUSE would look like. I know that this still needs a changelog fragment. I will add that once we decide on this. I have included how I've automated this so folks can see what the process looks like.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Licensing

ADDITIONAL INFORMATION

This is currently being discussed in ansible-community/community-topics#112.

@gotmax23
Copy link
Contributor Author

gotmax23 commented Jun 23, 2022

Current output of reuse lint: https://gist.github.com/gotmax23/b82d00caf4602d95fd0e379a1c1ac47c

I only added license comments for plugins/module_utils/_version.py and the files containing GNU General Public License v3.0+, so there are a lot of files missing license information. I can add bulk add GPL-3.0-or-later license headers to other files that don't currently have licensing information if you confirm that there's no other secondary licenses I missed. For the copyright part, there's some files that actually do have copyrights that aren't recognized by reuse, as it's picky about what formats it'll accept.

@@ -1,3 +1,5 @@
# SPDX-License-Identifier: GPL-3.0-or-later
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be directly after the current GPL line (now line 7, used to be line 5).

gotmax23 added 2 commits June 23, 2022 18:42
Automated with:

```
mkdir LICENSES
ln -sr COPYING LICENSES/GPL-3.0-or-later.txt
git mv PSF-license.txt LICENSES/PSF-2.0.txt
reuse addheader -l PSF-2.0 plugins/module_utils/_version.py
rg -l 'GNU General Public License v3.0+' | parallel reuse addheader -l GPL-3.0-or-later
```

Signed-off-by: Maxwell G <[email protected]>
These licenses were detected by licensecheck.

Signed-off-by: Maxwell G <[email protected]>
@felixfontein
Copy link
Collaborator

I created #430 with https://gist.github.com/felixfontein/3d9502e22d1461dc3baadddeeb9d9cd9 and some manual work.

@gotmax23
Copy link
Contributor Author

Closing in favor of #430

@gotmax23 gotmax23 closed this Jul 18, 2022
@github-actions
Copy link

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants