Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs build - update references to new repo #277

Merged
merged 1 commit into from
Jan 9, 2022
Merged

docs build - update references to new repo #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docs-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
permissions:
contents: read
name: Build Ansible Docs
uses: ansible-collections/community.hashi_vault/.github/workflows/_shared-docs-build-pr.yml@main
uses: ansible-community/github-docs-build/.github/workflows/_shared-docs-build-pr.yml@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at some point it makes sense to pin the version to a tag, but right now while things are still in flux let's better keep main :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that's not really trivial: ansible-community/github-docs-build#4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think while we're getting things set up and ironing out early bugs and such, main is better. I consider this in "preview" basically, and anyone who'd like to use it can do so, and if it causes CI failures the entire workflow can be temporarily disabled/enabled in each repo that uses it (in the GitHub UI, commits are not needed). We'll come up with a release strategy at some point; ansible-community/github-docs-build#4 does complicate the matter a bit, it's true.


comment:
permissions:
Expand All @@ -21,7 +21,7 @@ jobs:
name: PR comments
steps:
- name: PR comment
uses: ansible-collections/community.hashi_vault/.github/actions/docs/ansible-docs-build-comment@main
uses: ansible-community/github-docs-build/actions/ansible-docs-build-comment@main
with:
body-includes: '## Docs Build'
reactions: heart
Expand Down