Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs build - update references to new repo #277

Merged

Conversation

briantist
Copy link
Contributor

SUMMARY

Related:

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs build workflow

ADDITIONAL INFORMATION

N/A

@@ -11,7 +11,7 @@ jobs:
permissions:
contents: read
name: Build Ansible Docs
uses: ansible-collections/community.hashi_vault/.github/workflows/_shared-docs-build-pr.yml@main
uses: ansible-community/github-docs-build/.github/workflows/_shared-docs-build-pr.yml@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at some point it makes sense to pin the version to a tag, but right now while things are still in flux let's better keep main :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that's not really trivial: ansible-community/github-docs-build#4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think while we're getting things set up and ironing out early bugs and such, main is better. I consider this in "preview" basically, and anyone who'd like to use it can do so, and if it causes CI failures the entire workflow can be temporarily disabled/enabled in each repo that uses it (in the GitHub UI, commits are not needed). We'll come up with a release strategy at some point; ansible-community/github-docs-build#4 does complicate the matter a bit, it's true.

@felixfontein felixfontein merged commit 9ca2c61 into ansible-collections:main Jan 9, 2022
@felixfontein
Copy link
Collaborator

@briantist thanks!

@briantist briantist deleted the docs/build-new-repo branch May 3, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants