-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACME modules refactor #187
ACME modules refactor #187
Conversation
recheck |
I used this version to renew all my certificates, worked as expected. So the refactoring cannot be too butched :) I also did some ACME v1 testing with BuyPass's staging endpoint, which also worked, and I did revoke the old certificates (also worked). |
4c35d48
to
746b3d8
Compare
746b3d8
to
c0d8880
Compare
c0d8880
to
021cf60
Compare
021cf60
to
ad5dbbb
Compare
I've cleaned up the commit history a bit to make it easier to review commit by commit, which is probably a lot easier than reviewing the whole resulting diff. If anyone would prefer this to be split up into multiple PRs to simplify reviewing, I can happily do that (again). Just tell me what your preferences are. |
I tested the PR with our Let's Encrypt Collection (https://github.com/T-Systems-MMS/ansible-collection-letsencrypt/). Worked flawlessly. |
Restarting tests for a last time, will merge tomorrow if they passed. |
SUMMARY
Some refactoring of module_utils/acme.py: split that monster up, and clean up some of the code. Then it splits up the
ACMEAccount
object intoACMEClient
andACMEAccount
and improves the API w.r.t error handling. Finally it refactors the acme_certificate module to move certain code parts to module_utils.ISSUE TYPE
COMPONENT NAME
acme module_utils
acme_certificate