[WIP] ACME module_utils refactor 2 #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this PR with the unmodified modules from This PR is essentially done. The only reason it is marked "WIP" is that it contains all commits from #184. |
felixfontein
force-pushed
the
acme-refactor-2
branch
from
283a061 to
3e061a3
Compare
Merged
felixfontein
force-pushed
the
acme-refactor-2
branch
from
3e061a3 to
c2366e6
Compare
|
Let's just keep #187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR contains #184 and will be rebased once that's merged. This splits up the
ACMEAccountobject intoACMEClientandACMEAccountand improves the API w.r.t error handling.ISSUE TYPE
COMPONENT NAME
ACME module_utils and modules