-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faucet PoW #961
Closed
Closed
faucet PoW #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
tzemanovic
added a commit
that referenced
this pull request
Dec 26, 2022
tzemanovic
force-pushed
the
tomas/faucet-pow
branch
from
December 26, 2022 15:12
0753995
to
6359fab
Compare
Merged
* origin/tomas/gats-lifetimes-refactor: [ci] wasm checksums update core/storage: remove redundant `StorageWrite` impl for mut ref changelog: #966 core/storage_api: use GATs to hide lifetime in StorageRead trait core/storage/mockDB: remove unused `reverse_order` flag [ci] wasm checksums update changelog: add #912 wasm_for_tests: make storage: remove rev_iter_prefix, which doesn't work as expected test in apps/ledger/storage: test prefix iterators
tzemanovic
added a commit
that referenced
this pull request
Dec 28, 2022
tzemanovic
force-pushed
the
tomas/faucet-pow
branch
from
December 28, 2022 13:22
92d1d96
to
b26c7b3
Compare
tzemanovic
added a commit
that referenced
this pull request
Dec 28, 2022
tzemanovic
force-pushed
the
tomas/faucet-pow
branch
from
December 28, 2022 13:37
b26c7b3
to
6c84ae4
Compare
pls update wasm |
* origin/grarco/basic-fee: changelog: add #962 Fixes unit tests Fixes process proposal fee token Fixes fee value in tx contruction Adds fee burning and checks changed to 0.12.2 Namada 0.12.2 release: cherry-pick release improvements changelog: add #952 prepare_proposal: update comment to reflect hotfix prepare_proposal: use TxRecord struct on ABCI++ build missed a chain-id addition Prioritize wrapper txs during proposal construction Hot fix PrepareProposal added chain id and fixed install docs update pseudocode General housekeeping Reward distribution: general improvements Cubic slashing: general writing improvements Cubic slashing: add new improved pseudocode blurb (Rust-style) Cubic slashing: clarify slash iteration procedure and equation Cubic slashing: fix and improve plot quick fix to cubic slash changelog: add #911 changelog: add #876 test/core: run less cases on `update_epoch_after_its_duration` test changelog: add #945 ci: install cargo-about on release step make-package.sh: include license information in tarball release: add configuration for cargo-about changelog: add #943 make-package.sh: don't attempt to include matchmaker Namada 0.12.1 changelog: add #942 vp_verify_masp: avoid panicking unwrap()s changed the docker link (again) Changed the first header of pages to H1 in 2 occasions in Namada Specs Replaced non-breaking space with space to fix faulty formatting fix transfer args
tzemanovic
force-pushed
the
tomas/faucet-pow
branch
from
December 28, 2022 17:18
a2bf2f2
to
c7c2b7d
Compare
Merged
closing in favor of #969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #959
depends on #926 for storage keys macro, #966 for avoiding lifetime issues and #962 for tx fees
first commit from this PR: f7b6378
This is a breaking change for client - to be able to withdraw from token, client must request PoW challenge from the faucet, solve it and submit
tx_testnet_faucet_transfer.wasm
tx instead oftx_transfer.wasm
.This is non-breaking change for genesis as the added
faucet_pow_difficulty
is optional (defaults to0
- no challenge).TODOs:
init_chain.rs
faucet_pow_difficulty
from genesistx_faucet_transfer
wasm to sendtoken::Transfer
wrapped infaucet::Solution
and increment countertoken::Transfer
not(mainnet)
to allow fee-less tx (with minimum tx fees from Testnet fees #962)