make-package.sh: don't attempt to include matchmaker #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matchmaker has been removed, but the packaging script still attempts to include it. This does not break the script, because the name of the nonexistent matchmaker is the empty string, but is still incorrect.
Fraccaman
approved these changes
Dec 21, 2022
juped
added a commit
that referenced
this pull request
Dec 22, 2022
This cherry-picks the merges of branches 'namada/ray/no-matchmaker-in-package' (#943) and 'namada/ray/release-include-license' (#945) into main, as merged in commit 077f088. I was an incompetent maintainer here, and if you are reading this, you are paying the price. * namada/ray/no-matchmaker-in-package: changelog: add #943 make-package.sh: don't attempt to include matchmaker * namada/ray/release-include-license: changelog: add #945 ci: install cargo-about on release step make-package.sh: include license information in tarball release: add configuration for cargo-about
tzemanovic
added a commit
that referenced
this pull request
Dec 28, 2022
* origin/grarco/basic-fee: changelog: add #962 Fixes unit tests Fixes process proposal fee token Fixes fee value in tx contruction Adds fee burning and checks changed to 0.12.2 Namada 0.12.2 release: cherry-pick release improvements changelog: add #952 prepare_proposal: update comment to reflect hotfix prepare_proposal: use TxRecord struct on ABCI++ build missed a chain-id addition Prioritize wrapper txs during proposal construction Hot fix PrepareProposal added chain id and fixed install docs update pseudocode General housekeeping Reward distribution: general improvements Cubic slashing: general writing improvements Cubic slashing: add new improved pseudocode blurb (Rust-style) Cubic slashing: clarify slash iteration procedure and equation Cubic slashing: fix and improve plot quick fix to cubic slash changelog: add #911 changelog: add #876 test/core: run less cases on `update_epoch_after_its_duration` test changelog: add #945 ci: install cargo-about on release step make-package.sh: include license information in tarball release: add configuration for cargo-about changelog: add #943 make-package.sh: don't attempt to include matchmaker Namada 0.12.1 changelog: add #942 vp_verify_masp: avoid panicking unwrap()s changed the docker link (again) Changed the first header of pages to H1 in 2 occasions in Namada Specs Replaced non-breaking space with space to fix faulty formatting fix transfer args
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matchmaker has been removed, but the packaging script still attempts to include it. This does not break the script, because the name of the nonexistent matchmaker is the empty string, but is still incorrect.