Test wasms should be loaded via namada_test_utils crate
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2022
james-chf
force-pushed
the
james/mainline/namada-test-utils-wasms
branch
from
966e9f1 to
63f3a21
Compare
4 tasks
|
I have taken the simpler #894 for 0.14.0 - let's rebase this |
james-chf
force-pushed
the
james/mainline/namada-test-utils-wasms
branch
from
63f3a21 to
0a18a60
Compare
james-chf
commented
Feb 7, 2023
Comment on lines
+52
to
+64
| // crudely find the root of the repo, we can't rely on the `.git` | ||
| // directory being present, so look instead for the presence of a | ||
| // CHANGELOG.md file | ||
| let repo_root = cwd | ||
| .ancestors() | ||
| .find(|path| path.join("CHANGELOG.md").exists()) | ||
| .unwrap_or_else(|| { | ||
| panic!( | ||
| "Couldn't find the root of the repository for the current \ | ||
| working directory {}", | ||
| cwd.to_string_lossy() | ||
| ) | ||
| }); |
There was a problem hiding this comment.
We don't have the .git directory when running tests in CI, so this code crudely looks for the ancestor directory which has a CHANGELOG.md file, there is probably a better way to do this.
james-chf
changed the title
namada_test_utils crate enumerating test wasmsnamada_test_wasms crate
|
pls update wasm |
|
I've redone this PR on top of 0.14 |
james-chf
changed the title
namada_test_wasms cratenamada_test_utils crate
|
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Mar 31, 2023
* james/mainline/namada-test-utils-wasms: Update shared crate to use test utils Update namada_tests crate to use test utils Don't rely on the presence of .git directory Test that all test wasm files are present Update wasm crate to use test utils Update namada_apps to use test wasm utility code Add changelog Add test wasm utility code to test_utils
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #102 - this PR lays some groundwork for moving our
wasm_for_testsdirectory into the single wasm workspace.We use
wasm_for_testswasms in tests across multiple crates (namada_apps,namada,namada_tests,namada_wasm) - but we duplicate logic for getting the relative paths to and reading test wasms. This PR consolidates that logic to one place, so that it will be easier to migrate the directory later on.TestWasmsenum totest_utils/src/lib.rsTestWasmsenum instead