Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tx result message (backport #4039) #4059

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 20, 2024

Describe your changes

Closes #4020.

display_batch_resp now logs some information at the batch level followed by the results of the single inner txs. In case of OtherFailure we only print the error message for that specific failure instead of the entire tx result.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4039 done by [Mergify](https://mergify.com).

@grarco grarco self-requested a review November 20, 2024 18:15
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 20, 2024
@mergify mergify bot merged commit 38ac163 into maint-0.45 Nov 20, 2024
10 of 11 checks passed
@mergify mergify bot deleted the mergify/bp/maint-0.45/pr-4039 branch November 20, 2024 18:17
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (8cb51e2) to head (c887783).
Report is 6 commits behind head on maint-0.45.

Additional details and impacted files
@@              Coverage Diff               @@
##           maint-0.45    #4059      +/-   ##
==============================================
+ Coverage       74.04%   74.06%   +0.01%     
==============================================
  Files             341      341              
  Lines          106561   106571      +10     
==============================================
+ Hits            78906    78929      +23     
+ Misses          27655    27642      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant