Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tx result message #4039

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Improve tx result message #4039

merged 5 commits into from
Nov 20, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Nov 15, 2024

Describe your changes

Closes #4020.

display_batch_resp now logs some information at the batch level followed by the results of the single inner txs. In case of OtherFailure we only print the error message for that specific failure instead of the entire tx result.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (fb3a7cd) to head (91bd7f3).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
- Coverage   74.25%   74.25%   -0.01%     
==========================================
  Files         341      341              
  Lines      107325   107335      +10     
==========================================
+ Hits        79699    79702       +3     
- Misses      27626    27633       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

grarco added a commit that referenced this pull request Nov 15, 2024
@grarco grarco marked this pull request as ready for review November 15, 2024 16:54
@grarco
Copy link
Collaborator Author

grarco commented Nov 15, 2024

I need to fix some assertions in e2e tests

@grarco grarco force-pushed the grarco/adjust-tx-response-output branch from e459e56 to 91bd7f3 Compare November 19, 2024 18:51
@grarco
Copy link
Collaborator Author

grarco commented Nov 19, 2024

@tzemanovic @brentstone ok this is now ready for review

@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
@mergify mergify bot merged commit 2472527 into main Nov 20, 2024
24 checks passed
@mergify mergify bot deleted the grarco/adjust-tx-response-output branch November 20, 2024 18:13
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
(cherry picked from commit 91bd7f3)
mergify bot added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli breaking:SDK merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong tx response output
2 participants