-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tx result message #4039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
==========================================
- Coverage 74.25% 74.25% -0.01%
==========================================
Files 341 341
Lines 107325 107335 +10
==========================================
+ Hits 79699 79702 +3
- Misses 27626 27633 +7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I need to fix some assertions in e2e tests |
grarco
force-pushed
the
grarco/adjust-tx-response-output
branch
from
November 19, 2024 18:51
e459e56
to
91bd7f3
Compare
@tzemanovic @brentstone ok this is now ready for review |
tzemanovic
approved these changes
Nov 20, 2024
grarco
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Nov 20, 2024
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 20, 2024
Improve tx result message (backport #4039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:cli
breaking:SDK
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4020.
display_batch_resp
now logs some information at the batch level followed by the results of the single inner txs. In case ofOtherFailure
we only print the error message for that specific failure instead of the entire tx result.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo