VpEnv: add pre/post reads via storage api #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/vp-env-pre-post-via-storage-api
branch
from
70f9982 to
4422d8c
Compare
tzemanovic
force-pushed
the
tomas/vp-env-pre-post-via-storage-api
branch
from
4422d8c to
2d177f8
Compare
tzemanovic
added a commit
that referenced
this pull request
Sep 14, 2022
* tomas/vp-tx-env-concrete-error: changelog: add #465 [ci skip] wasm checksums update ledger: use storage_api::Error in VpEnv and TxEnv instead of generic update wasm checksums changelog: add #380 shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors
tzemanovic
added a commit
that referenced
this pull request
Sep 14, 2022
* tomas/vp-env-pre-post-via-storage-api: update wasm checksums changelog: add #380 shared: Add pre/post to VpEnv and use them to provide default impls
Closed
tzemanovic
added a commit
that referenced
this pull request
Sep 23, 2022
* tomas/vp-env-pre-post-via-storage-api: update wasm checksums changelog: add #380 shared: Add pre/post to VpEnv and use them to provide default impls
tzemanovic
added a commit
that referenced
this pull request
Sep 23, 2022
* tomas/vp-env-pre-post-via-storage-api: update wasm checksums changelog: add #380 shared: Add pre/post to VpEnv and use them to provide default impls
juped
added a commit
that referenced
this pull request
Sep 29, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 4, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 4, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 4, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 6, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 6, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 6, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 6, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 6, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 7, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 7, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 7, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 10, 2022
* draft: (394 commits) Revert "Update getting-started.md" Update getting-started.md changelog: add #442 rustdoc: fix outdated links make build-doc: only build rustdoc in this command [ci] remove drone ci: double the build-and-test timeout [ci] download masp paramters [ci] improve automation tool, add pls spawn devnet command [ci] added dev documentation build, added rust doc build I removed the limitation. I removed the limitation. encoding_spec: rm ":" from fragment links in e.g. `ed25519::PublicKey` docs/dev: update encoding spec generation update wasm checksums changelog: add #380 changelog: add #384 shared/storage: fix the height recorded for a new epoch shared: Add pre/post to VpEnv and use them to provide default impls changelog: add #1249 test/ledger: update last_epoch assertion ledger: fix last_epoch to only change when committing block changelog: add #337 Specify --target-dir when building wasms changelog: add #335 wasm checksums update test/vm_host_env: refactor prefix iter tests with new `iter_prefix` fn storage_api: build a nicer `iter_prefix` function on top of StorageRead changelog: add #334 wasm checksums update storage_api: add default borsh encoded read/write impl and handle errors update wasm checksums pos: update validator raw hash validation changelog: add #326 changelog: add #331 changelog: add #324 changelog: add #318 update wasm checksums fix missing StorageWrite for Storage merkle tree update storage: remove unnecessary clone add more comments for StorageRead lifetime with an example usage add <'iter> lifetime to StorageRead trait to get around lack of GATs ledger: impl StorageWrite for Storage ledger: factor out TxEnv write methods into a new StorageWrite trait [fix] use fetch-depth: 0 on tag pipeline Namada 0.7.1 fix spelling of 'features' in Cargo.toml realign cargo/wasm integrity changelog: add #278 test: allow to sign and verify secp256k1 client: add check on validator consensus key shared: optional secp256k1 signing and verification to avoid wasm bloat pick scheme for generating validator keys must use ed25519 for validator consensus key and node ID update rustdoc on PKH make fmt deps: enable secp256k1 in tendermint-rs handle secp256k1 in key_to_tendermint() fmt && clippy use heliaxdev/libsecp256k1 crate fork as dependency for now release: update release.toml for namada repo new test for zeroizing secp256k1 keys wrap libsecp256k1::SecretKey in a Box within SecretKey struct add a test to zeroize secp256k1 fix bug in supplying args to test_genesis_validators() make validator_key_to_json() compatible with ed25519 and secp256k1 keys fix bug to prevent generating keys with common SchemeType fix bug where we were generating a key with common scheme make fmt fix unit test test_toml_roundtrip to supply good validator keys e2e test_genesis_validators(): make each validator have different key scheme fix some comments fix bug in supplying keypair to Tendermint clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId change variable names in fns try_to_sk() and try_to_sig() to reduce confusion clean up code implementing Serialize/Deserialize, comment on certain implementations update wasm checksums remove Result layering for id_from_pk drop 'Consensus' from SchemeType enum variants incorporate options into key generation functions command line options for specifying key scheme initial commit for supporting secp256k1 keys clean and simplify code in id_from_pk() allow CL specification of a specific key scheme for the TxInitValidator improve write_tendermint_node_key() to produce the proper json given the underlying key scheme convert from common to underlying key type in id_from_pk() when constructing the TendermintNodeId ledger/pos: implement PosReadOnly using StorageRead trait ledger/tx: inherit StorageRead in TxEnv ledger/storage: impl StorageRead for Storage ledger/vp: impl StorageRead for WASM VPs pre and post state ledger/native_vp: implement StorageRead for pre and post state ledger: add StorageRead trait with extensible error type change variable names in fns try_to_sk() and try_to_sig() to reduce confusion pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes clean up code implementing Serialize/Deserialize, comment on certain implementations remove Result layering for id_from_pk ...
juped
added a commit
that referenced
this pull request
Oct 13, 2022
Draft drifted somewhat over this release cycle. We can clear this up with a merge-and-delete. * draft: (373 commits) changelog: add #452 feat: rocksdb use jemalloc feat: update rocksdb version [ci] wasm checksums update changelog: add #501 fix e2e tests fix e2e tests Misc refactoring Uses `end_epoch` in `query_proposal_result` Refactors governance e2e tests [ci] wasm checksums update changelog: #503 [ci] wasm checksums update remove unfinished lazy_set, lazy_hashset and lazy_hashmap for now ledger/storage/lazy: update lazy_set for updated trait LazyCollection Fixes specs [ci] wasm checksums update fix display proposal result in cli fix proposal_submission e2e test [misc] rebase ledger/storage/lazy: remove unused error cases WIP: Nested LazyMap validation and testing WIP: validation for lazy_map WIP: StateMachine tests for lazy_vec validation update wasm checksums changelog: add #500 remove intent gossiper, matchmaker and their deps Adds `max_proposal_period` governance parameter Removes `max_proposal_fund_transfer` parameter Use proposal `end_epoch` instead of `start_epoch` for voting power Skip tx whitelist for proposal code Rename `Treasury` to `SlashFund` fmt and fix clippy Speeds up testing Fixes `safe_exit` call only if `force` is not set [misc]: remove logs [fix]: votes accumulation Fixes test artifacts folder persistence Fixes e2e tests [fix]: e2e test [fix]: e2e test [misc]: clippy, fmt [fix]: error println [feat]: vote transaction validation [fix]: governance vp author address, proposal submission validation [fix]: bad validation condition [fix]: clippy, fmt [fix]: clippy, fmt [misc]: clippy, fmt [feat]: added total votes to query [fix]: governance overflow, proposal validation fixup! Merge branch 'yuji/multitoken' (#359) fixup! rustdoc: fix more broken links fixup! Sync with 'main' rustdoc: fix more broken links fixup! Sync with 'main' [ci] wasm checksums update changelog: add #359 change the balance format update a test wasm remove an error message [ci skip] wasm checksums update multitoken transfer and query post-conditions for Transition::Update + some comments quick bug and documentation fix update after rebase on #458, #465 storage/lazy_vec: add state machine test for lazy vec API storage/lazy_vec/validation: disallow unrecognized keys matching prefix impl LazyCollection trait for all the collections + refactor storage_api/collections/lazy: allow nested lazy collections in LazyMap add lazy_vec validation fix clippy storage_api/collections/lazy: add basic tests and missing methods cargo test test_lazy_vec_basics update lazy for explicit lifetime in StorageRead trait storage: add `Key::last` method, impl KeySeg for all ints Switch to use storage::KeySeg and add LazySet add lazy map without hashing refactored lazy collections, replaced hasher, added iter fmt && clippy add fn get_elem_key_by_hash to LazyMap lazy hash map first commit add lazy set (WIP), make LazyVec.get public add lazy vector create lazy data structures for storage access rustdoc: resolve ambiguous link changelog: add #465 fixup! Merge branch 'namada/tomas/sorted-prefix-iter' (#458) [ci skip] wasm checksums update ledger: use storage_api::Error in VpEnv and TxEnv instead of generic [ci skip] wasm checksums update changelog: add #458 tests: extend prefix iter tests for reverse order add support for rev_iter_prefix in storage and VP and tx envs test/vm_host_env: check prefix iter order in tx and VP shared/storage/key: add support for int/uint keys that maintain order deps: replace hex with data-encoding update wasm checksums changelog: add #380 changelog: add #384 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #334
trait VpEnv(implemented for native and WASM VP) 2 associated types and 2 methods to getpre/postview into the storage that implementstorage_api::StorageReadtrait. Unfortunately, without GATs this requires an explicit lifetime onVpEnv, but that is somewhat alleviated with HRTB with which one can simply useENV: for <'a> VpEnv<'a>for a trait bound that usesVpEnv.to-do:
StorageReadand there will be non-trivial conflict here (also due to lack of GATs as is done in here)