-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving inner_tx from WrapperTx to Tx. #1093
Conversation
5a0c9ff
to
d3b4848
Compare
d3b4848
to
69deef8
Compare
4b4b165
to
9b28738
Compare
c281592
to
e7f1e42
Compare
pls update wasm |
pls update wasm |
pls spawn devnet [anoma-devnet-0.13.0-zondax.toml,60,heliaxdev@1be9883,ON] |
pls spawn devnet [anoma-devnet-0.13.0-zondax.toml,60,heliaxdev@1be9883,ON] |
pls spawn devnet [anoma-devnet-0.13.0-zondax,60,heliaxdev@1be9883,ON] |
Devnet with chain id |
3d2bd33
to
bdfabc1
Compare
pls spawn devnet [anoma-devnet-0.13.0-zondax,60,heliaxdev@1be9883,ON] |
Devnet with chain id |
pls spawn devnet [anoma-devnet-0.13.0-zondax,60,heliaxdev@1be9883,ON] |
Devnet with chain id |
Yes, that's the plan. I'm working on a branch that applies the proposal #1255 to this branch. If this idea works out, then this PR will be superseded/redundant. #1156 was the original approach to enabling hardware wallet signing and is now superseded/redundant. I've just closed it now. |
The objective is to (with as little change as possible) make Namada transactions signable on hardware constrained wallets by making them smaller. The approach to this taken in this branch is to replace inner transactions (amongst other objects) with their hashes, and then only attach the encrypted payloads at the top level.
More precisely, the following changes have been made:
Tx
with a sum type that can either contain a hash or the literal codeinner_tx
field ofWrapperTx
leaving behindtx_hash
inner_tx
field toTx
representing an attached encrypted inner transactioninner_tx_code
field toTx
representing an attached encrypted inner transaction codeinner_tx
field against theWrapper::tx_hash
fieldinner_tx_code
field against the hash in theTx::code
field of the inner transactionThe implications of these changes are:
WrapperTx
is over the hash of an unencryptedTx