Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge queue: embarking main (9fb1037), #3629 and #3645 together #3649

Closed
wants to merge 10 commits into from
Closed

merge queue: embarking main (9fb1037), #3629 and #3645 together #3649

wants to merge 10 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 14, 2024 •
edited
Loading

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (9fb1037), #3629 and #3645 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3645.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (2)
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 3645
...

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.82353% with 52 lines in your changes missing coverage. Please review.

Project coverage is 61.18%. Comparing base (9fb1037) to head (0c0d90d).
Report is 10 commits behind head on main.

Files Patch % Lines
crates/sdk/src/rpc.rs 0.00% 24 Missing ⚠️
crates/apps_lib/src/config/genesis.rs 45.94% 20 Missing ⚠️
crates/governance/src/cli/onchain.rs 0.00% 3 Missing ⚠️
crates/governance/src/cli/validation.rs 0.00% 2 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 2 Missing ⚠️
crates/apps_lib/src/config/genesis/templates.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   61.22%   61.18%   -0.05%     
==========================================
  Files         312      312              
  Lines      101394   101373      -21     
==========================================
- Hits        62083    62029      -54     
- Misses      39311    39344      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Aug 14, 2024
@mergify mergify bot deleted the mergify/merge-queue/5a69219c70 branch August 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sug0 @Fraccaman @tzemanovic