Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow tnam1... addresses in balances.toml #3645

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 14, 2024

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (4cd4356) to head (5098900).
Report is 28 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/config/genesis.rs 45.94% 20 Missing ⚠️
crates/apps_lib/src/config/genesis/templates.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3645      +/-   ##
==========================================
- Coverage   61.24%   61.20%   -0.04%     
==========================================
  Files         312      312              
  Lines      101374   101362      -12     
==========================================
- Hits        62086    62043      -43     
- Misses      39288    39319      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 added the prio:high label Aug 14, 2024
@tzemanovic tzemanovic marked this pull request as ready for review August 14, 2024 14:36
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 14, 2024
mergify bot added a commit that referenced this pull request Aug 14, 2024
@mergify mergify bot merged commit 125af64 into main Aug 14, 2024
19 of 21 checks passed
@mergify mergify bot deleted the tiago/implicit-addr-balances-toml-fix branch August 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:genesis merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass prio:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants