-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve governance #262
Merged
Merged
Improve governance #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Aug 18, 2022
* fraccaman+grarco/governance-fixes: [ci]: update wasm checksums fmt and fix clippy Speeds up testing Fixes `safe_exit` call only if `force` is not set [misc]: remove logs [fix]: votes accumulation Revert gitignore Fixes test artifacts folder persistence Fixes e2e tests [fix]: e2e test [fix]: e2e test [misc]: clippy, fmt [fix]: error println [feat]: vote transaction validation [fix]: governance vp author address, proposal submission validation [fix]: bad validation condition [fix]: clippy, fmt [fix]: clippy, fmt [misc]: clippy, fmt [feat]: added total votes to query [fix]: governance overflow, proposal validation
Merged
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
* begin updating to identify parent account by ID * clean up * Update keyring to store "parentId" for derived accounts * Add store to persist selected parent account, return accounts by parentId * Implement message for account switching from extension * Set up parent account querying and messaging * Initialize parent account from storage for persistence * Clean up provider tests * Add events service/hooks, begin setting up for extension account changed * Simplify handler, prepare to broadcast chainId affected by changed accounts * Restructure extensionEvents service to account for additional extensions * Begin implementing event handlers in extension for accounts * Add background content service for events * continue hooking up content service, clean up * senderTabId shouldn't be required for now, hook up to Settings page * Clean up * Move initial call to dispatch account changed message to service * Simplified event broadcast and provider in interface * Update to track connected interfaces by tab ID * Clean up * Add single store instantiated at start up for tracking tab IDs * clean up * clean up, only append to store if chain ID matches * Fix to invoke "connect()" when querying accounts, needed to track tab ID * Move tab storage to local storage, track timestamp to later expire * Add logic to update tab timestamp when interface reconnects * Simplify logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from anoma/anoma#1111
fixes #120