Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve governance #262

Merged
merged 21 commits into from
Oct 13, 2022
Merged

Improve governance #262

merged 21 commits into from
Oct 13, 2022

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 2, 2022

moved from anoma/anoma#1111

fixes #120

  • Fix an overflow bug when computing voting power tally
  • Add validation of proposal .json when creating a new proposal
  • Fix a bug when computing total amount of nay/yay
  • Improving CLI UI

tzemanovic added a commit that referenced this pull request Aug 18, 2022
* fraccaman+grarco/governance-fixes:
  [ci]: update wasm checksums
  fmt and fix clippy
  Speeds up testing
  Fixes `safe_exit` call only if `force` is not set
  [misc]: remove logs
  [fix]: votes accumulation
  Revert gitignore
  Fixes test artifacts folder persistence
  Fixes e2e tests
  [fix]: e2e test
  [fix]: e2e test
  [misc]: clippy, fmt
  [fix]: error println
  [feat]: vote transaction validation
  [fix]: governance vp author address, proposal submission validation
  [fix]: bad validation condition
  [fix]: clippy, fmt
  [fix]: clippy, fmt
  [misc]: clippy, fmt
  [feat]: added total votes to query
  [fix]: governance overflow, proposal validation
@tzemanovic tzemanovic mentioned this pull request Aug 18, 2022
35 tasks
@grarco grarco mentioned this pull request Sep 22, 2022
@juped juped merged commit d6eeca9 into main Oct 13, 2022
@juped juped deleted the fraccaman+grarco/governance-fixes branch October 13, 2022 06:51
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
* begin updating to identify parent account by ID

* clean up

* Update keyring to store "parentId" for derived accounts

* Add store to persist selected parent account, return accounts by
parentId

* Implement message for account switching from extension

* Set up parent account querying and messaging

* Initialize parent account from storage for persistence

* Clean up provider tests

* Add events service/hooks, begin setting up for extension account changed

* Simplify handler, prepare to broadcast chainId affected by changed
accounts

* Restructure extensionEvents service to account for additional extensions

* Begin implementing event handlers in extension for accounts

* Add background content service for events

* continue hooking up content service, clean up

* senderTabId shouldn't be required for now, hook up to Settings page

* Clean up

* Move initial call to dispatch account changed message to service

* Simplified event broadcast and provider in interface

* Update to track connected interfaces by tab ID

* Clean up

* Add single store instantiated at start up for tracking tab IDs

* clean up

* clean up, only append to store if chain ID matches

* Fix to invoke "connect()" when querying accounts, needed to track tab ID

* Move tab storage to local storage, track timestamp to later expire

* Add logic to update tab timestamp when interface reconnects

* Simplify logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The E2E test for offline proposals does not clean up its files
4 participants