The E2E test for offline proposals does not clean up its files #120
Assignees
Labels
Comments
batconjurer
added
bug
|
There's also a duplication of files since the proposal and vote files appear both in the |
Merged
Repository owner
moved this from Pending Devnet
to Tested in Devnet
in Namada-Old
Oct 13, 2022
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this issue
Mar 1, 2024
* Begin setting up KeyRing & accounts storage * Adding a simple typed state class to keyring * Address helper to obtain ImplicitAddress, cargo update * Continue hooking up KeyRing to services * Fix broken imports, confirm message works in popup * Adding msg type for fetch generated mnemonic, update tests * Beginning components package; get styled-components with theme working * Disable devtool sourcemapping, add plugin for extension reloading (all browsers) * Properly include svg assets, port additional components into shared package * Fix issue on reloader plugin * fix module resolution, clean up imports * Remove unnecessary assignment * Consolidate types from Keplr into our own * Validate mnemonic phrase before storing, better error handling in wasm * Minor clean up, better type State class so as not to instantiate directly * Adding mnemonic/password creation screens, added README for types * Split set-up flow into new tab for initial account * Begin wiring up account derivation in service, generate implicit address to store and return * Add account derivation to completion process, load and display accounts * Better error-handling, add user feedback on account creation * Adding AccountListing components * Clean up configs, layout, fixed bug in key storage * Improved naming conventions, add implementation for scrypt, tests * Implement optional custom Scrypt params * Updated documentation * Add aes dependency, being basic implementation * KeyRing state is no longer duplicated, storage is only source of truth * Add icon for copy to clipboard, additional styling, update styled config * description -> alias to match cli, clean up * Adding UI for adding a new derived account with basic validation * Fix bug where alias is not being saved * Add "alias" as a field during setup * Updating for consistency, rough pass at styling derivation form * Move path items to number, validate inputs, set primes appropriately * Begin implementing kdf derived key as bytes * Fix naming on file extension, begin components for password auth * Add basic login/logout functionality, hook up to service backend * Clean up effects, check keyring status on auth * Fix minor bug when locking/unlocking wallet. Switch to numeric input * Fix sourcemap warning, reuse lock button wrapper, minor style * Update kdf libs for password hashing, tests, serializing params to JsValue * Add serializable struct and associated tests (params + bytes) * Fix naming convention, create storage type containing params * Moving storage updates to separate PR * Adding support for argon2 and scrypt pbkdf hashing * Cover Scrypt in jest tests * Clean up * Remove unused dependencies in this branch * 2 more dependencies that are unneeded * Adding dependencies * Clean up * Add serialize to key+params (argon2), add tests * Fix for Cargo * Improve custom params, add salt as an option * Initial implementation of AES+Argon2 with related tests * Clarify naming in jest test * Update scrypt to accept salt, optional params, similar tests with AES * Clean up * Add missing test for scrypt with provided salt, clean up * Clean up Rust lib, begin to implement encrypt/decrypt in KeyRing * Add simple Rng mod for generating random bytes * Touch up TS types * clean up tests * Connect KeyRing instance to new storage types, update UI * Minor styling, match account hierarchy to other wallets * Improve naming conventions, comments, updated for consistency * Begin moving transaction args to Borsh-serialized data * Minor style issue in rs * Update wasm libs to support Borsh serialized data * Define schema for remaining shared types, update tests * Split Proxy off from InjectedAnoma, improved typing * Simplify Message types * Split off proxy to individual classes (proxy vs injected-proxy) * Move borsh types to @anoma/types to decouple from wasm dependency * Move secret out of schema, add documentation for usage in @anoma/types * Update amount types to micro to match Namada, update tests * Split off Signer functionality in Rust, hook up to KeyRing service * formatting, allow more errors to return to TS from wasm * Move types to u64 where required by Namada, lint pass, docs * Continued improving types * Clean up, add note to refactor Router messages * Create RoutedMessage type, with overridable generic type arg * Add basic Signer interface, move types to location where they can be shared * Update types for Signer, map TS naming conventions to Rust struct * Set up encoding methods, move types to shared location * Update build to support buffer, hook up encoding and signing * Remove fail on status * Couple minor fixes that slipped through the cracks * Further wiring up of signTx service * Additional message types for generating structs in wasm * Add base64 encoding to pass binary data via postMessage * Move other transaction message to base64 for postMessage * Clean up unit tests, improve shared lib * Clean-up, improve readability * Additional test coverage * In the case of mnemonic stored account, derive a pk to sign tx * Clean up - remove temp comments, unnecessary checks * Hook up ibc/init-account, fix types on chain messages * Consistency in validation errors for KeyRing messages * Remove duplicate types, remove cruft, fix typing, add lint to storage * Refactored storage to fix linting issue, simplified * Load coinType from default chain config (set to 1 for testnet/all coins) * Updated additional derivation path, finish linting * Additional linting item, fix very minor style issue * Initial change to establish port, keeps Chrome service worker alive * Updated to invoke port connection on `Anoma.connect()` * Hashing out persisting sessions for more than 5 min * Cleaning up test code - track timestamp to detect inactivity (TODO) * Remove logic that was accidentally reintroduced * Properly encode ImplicitAddress before storing * Fix address formatting, refactor session functionality to distinct class * Update tests, continue working with session ports * Clean up interaction just a bit on forms, remove timestamp for now * Move startSession call to a more appropriate place * Timeout on inactivity is behaving properly in Chrome now * Clean up, add cases in message handler for messages from background * Move provider-specific messages out of background, handle session disconnect * Fix minor linting issues * Add StoredRecord to Store interface * Update KVStore usage of generic types * Minor updates per feedback * Begin adding support for shielded Transfer to existing libs * Update schema for zcash transactions, fix optional fields, update tests * Fix optional type * Improved naming convention, indicating an encoded msg is expected * Provide crude initial bindings for zip32 * Clean up, improve error message for child derivation * Fix failing test * Return keys as bytes from master and child keys, update tests * Improve tests, use Argon2id params from config where it is easily updated * Add addresses to ShieldedHDWallet * Add constructor, validation to Keys struct * Formatting, add constructor * Moved to masp_primitives::zip32, updated tests accordingly * Add BorshSerialize to keys for passing to @anoma/shared types, update tests * Instantiate masp types from Borsh-encoded slice * Add PaymentAddress encoding, deserialized from Borsh * Add basic UI for creating shielded accounts * Consolidate shielded & transparent derive messages, clean up * Add logic to determint display for shielded vs non-shielded accounts * Clean up, comments * Add hashing, pinned and is_pinned methods to PaymentAddress * Add transparent label to toggle * Update for consistency * Remove session * Removing unused Session.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running the
e2e::ledger_test::proposal_offlinee2e test, files get created in theproposal-test-datafolder that aren't cleaned up if the test passes. These include vote files tagged to addresses that are randomly created each run of the e2e tests but are all supposed to belong to Albert. Thus if you run the test again, the client tries to tally votes from these leftover files but cannot find them in storage, causing a panic. Thus this folder must have its contents deleted manually after every test run.The text was updated successfully, but these errors were encountered: