Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: fix cmd assert #247

Merged
merged 0 commits into from
Aug 16, 2022
Merged

e2e tests: fix cmd assert #247

merged 0 commits into from
Aug 16, 2022

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 1, 2022

based on #234

A call to assert_success/failure in e2e tests on a command with unread output (e.g. the output after a exp_string match) the call will just hang. To get around it, we can discard the unread output first

tzemanovic added a commit that referenced this pull request Aug 1, 2022
@tzemanovic tzemanovic marked this pull request as ready for review August 1, 2022 15:27
tzemanovic added a commit that referenced this pull request Aug 1, 2022
* tomas/e2e-fix-cmd-assert:
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
tzemanovic added a commit that referenced this pull request Aug 1, 2022
* tomas/e2e-fix-cmd-assert:
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
tzemanovic added a commit that referenced this pull request Aug 4, 2022
@tzemanovic tzemanovic force-pushed the tomas/e2e-fix-cmd-assert branch from 110c501 to 0bacc95 Compare August 4, 2022 14:47
tzemanovic added a commit that referenced this pull request Aug 4, 2022
* tomas/e2e-fix-cmd-assert:
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
james-chf added a commit that referenced this pull request Aug 11, 2022
* tomas/remove-abci-integration:
  cli: update binary names dispatch for namada
  update the changelog config to namada repo
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
  [ci] improve e2e log upload to add validator logs
  ci: sync dockerfile for wasm builds, build in container
  [ci] docker use rust:1.61.0
  update wasm checksums
  [ci] run specific step in docker container
  [ci] change tendermint version
  ci: allow ci to read docker images
  ci: correct tendermint settings for e2e tests
  ci: use anoma-owned docker images
  ci: improve python style of scripts
  scripts: revert change to package `git describe`
  ci: move to github actions
  build: rename package to 'namada'
  docker: upgrade wasm-opt 101 -> 109
  docker: rename anoma -> namada
  Remove old proof-of-stake file
  Improving governance specs
  [docs]: Cleanup spex suggestions
  [docs]: My review of the specs
  Replace anoma with namada
  Misc fixes
  Rename to specs/
  specs: update TS
  fix link after renaming
  rename folder spec to specs
  Added the conversion query specifications.
  Remove nix CI script
  Remove nix docs from README
  Added information on Convert note encodings.
  Started adding detail on convert descriptions.
  Added specs for pinned transactions.
  Moved MASP client documentation from the specs folder.
  fix: katex rendering code blocks bug when using '$'
  [docs]: My review of the specs
  Add pages for default account, fungible token, multisignature VPs
  Move files around
  Minor edits
  Description of shielded pool rewards
  Pull back in PGF changes
  Update fee system
  Alter base-ledger/execution
  Fix links so rendering works
  Avoid using h1, too big
  Update Makefile & book.toml
  Remove duplicate images
  Summarize economics section
  Update summaries & a bit of cleanup
  Changes to base ledger section
  Add PGF proposal; various tweaks
  Port latest specs from anoma/specs
  Update index.md
  Reorganise specs
  Alter index; port MASP; rename a few files
  Initial port of specs
  changelog: add #1142
  switch from a fork to expectrl v0.5.2

# Conflicts:
#	Cargo.lock
#	Makefile
#	apps/Cargo.toml
#	apps/src/lib/node/ledger/mod.rs
#	apps/src/lib/node/ledger/shell/finalize_block.rs
#	apps/src/lib/node/ledger/shell/mod.rs
#	apps/src/lib/node/ledger/shell/prepare_proposal.rs
#	apps/src/lib/node/ledger/shell/process_proposal.rs
#	apps/src/lib/node/ledger/shims/abcipp_shim.rs
#	documentation/specs/src/economics/inflation-system.md
#	shared/Cargo.toml
#	tests/Cargo.toml
#	tests/src/e2e/ledger_tests.rs
#	wasm/checksums.json
#	wasm/tx_template/Cargo.lock
#	wasm/tx_template/Cargo.toml
#	wasm/vp_template/Cargo.lock
#	wasm/vp_template/Cargo.toml
#	wasm/wasm_source/Cargo.lock
#	wasm/wasm_source/Cargo.toml
#	wasm_for_tests/wasm_source/Cargo.lock
tzemanovic added a commit that referenced this pull request Aug 16, 2022
@tzemanovic tzemanovic merged commit cff7d0f into main Aug 16, 2022
@tzemanovic tzemanovic force-pushed the tomas/e2e-fix-cmd-assert branch from 0bacc95 to 356b901 Compare August 16, 2022 18:35
tzemanovic added a commit that referenced this pull request Aug 19, 2022
* brent/922/zeroize-secret-keys:
  changelog: add #277
  [ci skip] wasm checksums update
  move zeroize test out of macro (also in advance of incorporating secp256k1)
  make fmt
  wrap SigningKey in a Box pointer when placing into SecretKey struct, test that memory is actually zeroized after dropping SecretKey
  changes to Cargo.toml and Cargo.lock from adding latest version of zeroize crate
  update the changelog config to namada repo
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
  [ci] improve e2e log upload to add validator logs
tzemanovic added a commit that referenced this pull request Aug 24, 2022
* tomas/remove-evidence-params:
  changelog: add #1248
  shell: skip and log outdated evidence in the shell
  shell: remove TM consensus evidence parameters
  update the changelog config to namada repo
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
  [ci] improve e2e log upload to add validator logs
tzemanovic added a commit that referenced this pull request Sep 23, 2022
* tomas/remove-evidence-params:
  changelog: add #1248
  shell: skip and log outdated evidence in the shell
  shell: remove TM consensus evidence parameters
  update the changelog config to namada repo
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
  [ci] improve e2e log upload to add validator logs
tzemanovic added a commit that referenced this pull request Sep 23, 2022
* tomas/remove-evidence-params:
  changelog: add #1248
  shell: skip and log outdated evidence in the shell
  shell: remove TM consensus evidence parameters
  update the changelog config to namada repo
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
  changelog: add #247
  test/e2e: update assert_success/failure to first consume output
  [ci] improve e2e log upload to add validator logs
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant