Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ABCI++ the default and remove ABCI #224

Merged
merged 0 commits into from
Aug 17, 2022
Merged

make ABCI++ the default and remove ABCI #224

merged 0 commits into from
Aug 17, 2022

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 27, 2022

based on #247

@juped
Copy link
Member

juped commented Jul 27, 2022

We should base this on #222 which I am about to merge and include the relevant CI changes

@tzemanovic
Copy link
Member Author

We should base this on #222 which I am about to merge and include the relevant CI changes

There's an outstanding issue with non-validator nodes (the result in non-deterministic in e2e tests, because non-validator nodes may or may not receive ABCI++ ProcessProposal). I'm just working on a fix, will rebase too

@tzemanovic tzemanovic force-pushed the tomas/remove-abci branch 4 times, most recently from 078477b to 6beb558 Compare July 28, 2022 14:54
@tzemanovic
Copy link
Member Author

pls update wasm

@Fraccaman Fraccaman force-pushed the tomas/remove-abci branch from 5d8d7fb to 251da4d Compare July 28, 2022 16:02
@tzemanovic
Copy link
Member Author

pls update wasm

@tzemanovic tzemanovic force-pushed the tomas/remove-abci branch 2 times, most recently from 4b5c7bd to ae7c418 Compare July 29, 2022 15:00
@tzemanovic
Copy link
Member Author

pls publish wasm

@tzemanovic tzemanovic marked this pull request as ready for review July 29, 2022 15:54
@juped
Copy link
Member

juped commented Jul 29, 2022

wasm is still a bit busted until #234 is done, btw

@Fraccaman
Copy link
Member

@juped #234 looks good to me, can you check it on your side?

@juped
Copy link
Member

juped commented Aug 1, 2022

looks good, need to factor out unrelated changes a bit

@tzemanovic
Copy link
Member Author

launched a devnet namada-devnet-0.5.4d591ed23da2

@tzemanovic
Copy link
Member Author

looks good, need to factor out unrelated changes a bit

thanks, will do

@tzemanovic
Copy link
Member Author

later, we should also refactor the abcipp_shim and shim_types

tzemanovic added a commit that referenced this pull request Aug 1, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* tomas/remove-abci:
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
tzemanovic added a commit that referenced this pull request Aug 1, 2022
* tomas/remove-abci:
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
tzemanovic added a commit that referenced this pull request Aug 4, 2022
* tomas/remove-abci:
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
tzemanovic added a commit that referenced this pull request Aug 16, 2022
* tomas/remove-abci:
  [ci] wasm checksums update
  ledger: debug log some ABCI++ requests
  ledger: make prepare_proposal and process_proposal stateless
  ledger: refactor tx_queue
  scripts/get_tendermint: update for ABCI++ temp fork release
  test/e2e/ledger: enable ignored tests for ABCI++ workaround
  shell: process transaction when `ProcessProposal` hasn't (non-validator)
  make: remove "*-abci-plus-plus"
  all: remove "ABCI" conditional compilation
  deps: remove ABCI dependencies, use ABCI++ as default
@tzemanovic tzemanovic merged commit 5f30002 into main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants