-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ABCI++ the default and remove ABCI #224
Conversation
We should base this on #222 which I am about to merge and include the relevant CI changes |
There's an outstanding issue with non-validator nodes (the result in non-deterministic in e2e tests, because non-validator nodes may or may not receive ABCI++ |
078477b
to
6beb558
Compare
pls update wasm |
6beb558
to
251da4d
Compare
5d8d7fb
to
251da4d
Compare
pls update wasm |
4b5c7bd
to
ae7c418
Compare
pls publish wasm |
wasm is still a bit busted until #234 is done, btw |
looks good, need to factor out unrelated changes a bit |
launched a devnet namada-devnet-0.5.4d591ed23da2 |
thanks, will do |
ae7c418
to
fdb12ed
Compare
later, we should also refactor the abcipp_shim and shim_types |
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
fdb12ed
to
855d0db
Compare
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
855d0db
to
5f30002
Compare
based on #247