Validator metadata #2045
Validator metadata #2045
Conversation
brentstone
force-pushed
the
brent/validator-metadata
branch
from
05f3410 to
daa1a2f
Compare
|
Adding an email should be required, with a tx implemented to change this field if need be (it should not be immutable) Ideally, this should allow us to select for everyone who is either active and without VP and those who are active and have VP if there is ever a need to coordinate. |
apps/src/lib/config/genesis.rs
Outdated
| @@ -200,6 +201,16 @@ pub mod genesis_config { | |||
| /// Tendermint node key is used to derive Tendermint node ID for node | |||
| /// authentication | |||
| pub tendermint_node_key: Option<HexString>, | |||
| /// Validator email (required) | |||
| pub email: String, | |||
There was a problem hiding this comment.
@s0uk4 @Fraccaman because this is required, this will be a breaking change for testnet setup - you'll need to ask all validators to add this
There was a problem hiding this comment.
It can just be an empty string. We can't validate the email anyway during the submission.
There was a problem hiding this comment.
So based on that I think we can also make this an option too. Ie, someone can make their email potatoe@[email protected], which is equivalent to None really.
There was a problem hiding this comment.
even if this is true, that's the validator's problem, not ours. they need to put an email in for the case where the network needs them to respond to potential security issues. asking for an email field helps us, but it's also a favor to the valds themselves.
if they put in an empty string rather than the proper email and there is a breaking change or risk requiring validators to respond, and they don't see discord /or/ the email, they will go down/put the network at risk and be penalized, which means they will lose money. there is incentive for them not to defect here.
There was a problem hiding this comment.
It's unclear to me if @s0uk4 is convincing others here, so can we get some clear consensus on how the email should be done? Atm, it is required, and providing an empty string for this arg will return an error, since empty strings are used to indicate that one wants to remove metadata from storage (i.e. if I want to delete my validator website, I pass --website "" at the CLI).
|
I'll squash the fixup commits to get this rdy |
tzemanovic
force-pushed
the
brent/validator-metadata
branch
from
7b9e92f to
8f941d2
Compare
tzemanovic
force-pushed
the
brent/validator-metadata
branch
from
8f941d2 to
8476698
Compare
brentstone
force-pushed
the
brent/validator-metadata
branch
5 times, most recently
from
2e38800 to
ff0a027
Compare
brentstone
force-pushed
the
brent/validator-metadata
branch
3 times, most recently
from
c881f1a to
0bec3ef
Compare
brentstone
force-pushed
the
brent/validator-metadata
branch
from
0bec3ef to
618c927
Compare
brentstone
force-pushed
the
brent/validator-metadata
branch
from
618c927 to
3268996
Compare
* brent/validator-metadata: new comments and logging for keys regenerate masp proofs remove hard-coded keys, get from pre-genesis wallet get validator consensus key from wallet in tests rather than hard-code fix e2e tests add email to transactions.toml and update sigs update with new genesis + remove alias changelog: add #1945 validator metadata with a tx to change it on-chain
Describe your changes
Closes #1609.
This PR implements the storage of validator metadata, such as an email, description, website, and discord_handle. An email is the only required piece of this data. A TX is implemented to change this metadata that also allows one to change a validator's commission rate at the same time.
Indicate on which release or other PRs this topic is based on
v0.25.0
Checklist before merging to
draft