fix from review comments

anoma · Oct 27, 2023 · 8f941d2 · 8f941d2
1 parent 45f547c
commit 8f941d2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/ethereum_bridge/Cargo.toml b/ethereum_bridge/Cargo.toml
@@ -48,6 +48,7 @@ tracing = "0.1.30"
 [dev-dependencies]
 # Added "testing" feature.
 namada_core = {path = "../core", default-features = false, features = ["ferveo-tpke", "ethers-derive", "testing"]}
+namada_proof_of_stake = {path = "../proof_of_stake", default-features = false, features = ["testing"]}
 assert_matches.workspace = true
 data-encoding.workspace = true
 ethabi.workspace = true

diff --git a/proof_of_stake/src/types.rs b/proof_of_stake/src/types.rs
@@ -357,6 +357,7 @@ pub struct ValidatorMetaData {
     pub discord_handle: Option<String>,
 }
 
+#[cfg(any(test, feature = "testing"))]
 impl Default for ValidatorMetaData {
     fn default() -> Self {
         Self {

diff --git a/sdk/src/tx.rs b/sdk/src/tx.rs
@@ -647,8 +647,7 @@ pub async fn build_validator_metadata_change<'a>(
             edisplay_line!(
                 context.io(),
                 "Cannot remove a validator's email, which was implied by the \
-                 string {}",
-                email
+                 empty string"
             );
             return Err(Error::from(TxError::InvalidEmail));
         }