Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support validators' hostnames in config #1886

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Sep 11, 2023

Describe your changes

Closes #576.
Closes #929.

Allows the usage of hostnames instead of IP addresses for validators in configuration.

Indicate on which release or other PRs this topic is based on

v0.22.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco force-pushed the grarco/validators-by-hostnames branch 2 times, most recently from 7fc03e8 to bb2f985 Compare September 12, 2023 10:07
@grarco grarco force-pushed the grarco/validators-by-hostnames branch from bb2f985 to a57bd89 Compare September 12, 2023 12:21
@grarco grarco mentioned this pull request Sep 12, 2023
@grarco grarco marked this pull request as ready for review September 13, 2023 15:20
Fraccaman added a commit that referenced this pull request Sep 25, 2023
* origin/grarco/validators-by-hostnames:
  changelog: add #1886
  Clippy + fmt
  Adjusts fixme comment on hostname resolution
  Refactors `get_actor_rpc`
  Changes `SocketAddr` to `String` to identify validators by hostnames
@brentstone brentstone merged commit c3fc3ad into main Sep 25, 2023
@brentstone brentstone deleted the grarco/validators-by-hostnames branch September 25, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants